Skip to content

Try demangling names before forwarding them to the profiler - #3683

Merged
fitzgen merged 1 commit into
mainfrom
demangle-names-in-profiling
Jan 12, 2022
Merged

Try demangling names before forwarding them to the profiler#3683
fitzgen merged 1 commit into
mainfrom
demangle-names-in-profiling

Conversation

@bnjbvr

@bnjbvr bnjbvr commented Jan 12, 2022

Copy link
Copy Markdown
Member

Before this PR, each profiler (perf/vtune, at the moment) had to have a
demangler for each of the programming languages that could have been
compiled to wasm and fed into wasmtime. With this, wasmtime now
demangles names before even forwarding them to the underlying profiler,
which makes for a unified representation in profilers, and avoids
incorrect demangling in profilers.

Before this PR, each profiler (perf/vtune, at the moment) had to have a
demangler for each of the programming languages that could have been
compiled to wasm and fed into wasmtime. With this, wasmtime now
demangles names before even forwarding them to the underlying profiler,
which makes for a unified representation in profilers, and avoids
incorrect demangling in profilers.
@fitzgen
fitzgen merged commit eeca41d into main Jan 12, 2022
@fitzgen
fitzgen deleted the demangle-names-in-profiling branch January 12, 2022 18:31
@alexcrichton

Copy link
Copy Markdown
Member

Oh oops looks like I was too slow, but in any case this is actually a duplicate of this demangling logic so if you're up for it it'd be great to have some sort of helper function in wasmtime-jit which wasmtime::Trap calls into and this function shares as well.

Similarly if you're interested in pushing on vtune one feature the vtune support is missing is loading profiling information for trampolines. Trampolines were added recently to jitdump support but were skipped as part of vtune since I didn't know how to modify it.

@bnjbvr

bnjbvr commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

@alexcrichton, I will look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants