Skip to content

cranelift: Port vselect over to ISLE on x64 - #3659

Merged
fitzgen merged 1 commit into
bytecodealliance:mainfrom
fitzgen:vselect-isle
Jan 6, 2022
Merged

cranelift: Port vselect over to ISLE on x64#3659
fitzgen merged 1 commit into
bytecodealliance:mainfrom
fitzgen:vselect-isle

Conversation

@fitzgen

@fitzgen fitzgen commented Jan 6, 2022

Copy link
Copy Markdown
Member

No description provided.

@fitzgen
fitzgen requested a review from alexcrichton January 6, 2022 22:11
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen isle Related to the ISLE domain-specific language labels Jan 6, 2022
@github-actions

github-actions Bot commented Jan 6, 2022

Copy link
Copy Markdown

Subscribe to Label Action

cc @cfallin, @fitzgen

Details This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@abrown

abrown commented Jan 6, 2022

Copy link
Copy Markdown
Member

@fitzgen, just a heads up that I have a "port select to ISLE" change in-progress; just letting you know since I've seen some select-related changes recently. Do you want to take over select?

@fitzgen
fitzgen merged commit 6b5e9d8 into bytecodealliance:main Jan 6, 2022
@fitzgen
fitzgen deleted the vselect-isle branch January 6, 2022 22:51
@fitzgen

fitzgen commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

Do you want to take over select?

I don't need to at the moment, I have my hands full with sshr now.

v1 = iabs v0
return v1
}
; run: %iabs_i32x4([0 2147483647 -2147483647 -2147483648]) == [0 2147483647 2147483647 -2147483648]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove these tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants