Skip to content

wiggle: delete GuestErrorConversion, improve some error reporting - #2760

Merged
pchickey merged 7 commits into
mainfrom
pch/wiggle_error_reporting
Mar 24, 2021
Merged

wiggle: delete GuestErrorConversion, improve some error reporting#2760
pchickey merged 7 commits into
mainfrom
pch/wiggle_error_reporting

Conversation

@pchickey

Copy link
Copy Markdown
Contributor

With the latest renovation to witx, wiggle no longer generates code that calls the GuestErrorConversion trait to transform a GuestError into the function's error type. Instead, wiggle will trap execution if a GuestError is thrown in generated code.

This PR removes generation of the GuestErrorConversion trait. Users can delete their impls of it - they are dead code.

I also fixed up the Display impl of the GuestError::InFunc variant to be more useful, and deleted GuestError::InDataField because it was also dead code.

@pchickey
pchickey requested a review from alexcrichton March 24, 2021 05:23
@github-actions github-actions Bot added the wasi Issues pertaining to WASI label Mar 24, 2021
@github-actions

Copy link
Copy Markdown

Subscribe to Label Action

cc @kubkon

Details This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@pchickey
pchickey merged commit db7ec95 into main Mar 24, 2021
@pchickey
pchickey deleted the pch/wiggle_error_reporting branch March 24, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasi Issues pertaining to WASI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants