Skip to content

Add Package::from_wit convenience #92

Description

@rylev

It would be nice to have some sort of convenience for declaring a wac_types::Package from wit files.

Essentially replacing this code:

let mut resolve = wit_parser::Resolve::new();
let pkg = if path.is_dir()
   let (pkg, _) = resolve.push_dir(path)?;
   pkg
} else {
  let unresolved = wit_parser::UnresolvedPackage::parse_file(&path)?;
  resolve.push(unresolved)?
};
let bytes = wit_component::encode(Some(true), &resolve, pkg)?;
wac_graph::types::Package::from_bytes(
  name,
  None,
  bytes.to_owned(),
  types,
)

Of course, this ties wac_types to the convention from wit_parser, but the wac_cli already does this, so I don't see why it would be inappropriate in wac_types.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions