Repository navigation
test(p2-shim): regression tests for symlink - #2234
Merged
vados-cosmonic merged 1 commit intoOct 11, 2026
Merged
vados-cosmonic merged 1 commit into
vados-cosmonic merged 1 commit into
Conversation
eduardomourar
requested review from
andreiltd and
vados-cosmonic
as code owners
October 9, 2026 09:36
eduardomourar
force-pushed
the
chore/test-p2-shim-symlink-regression
branch
from
October 9, 2026 09:41
189c6ec to
ebabfe6
Compare
eduardomourar
force-pushed
the
chore/test-p2-shim-symlink-regression
branch
from
October 9, 2026 13:40
ebabfe6 to
9ee56f6
Compare
vados-cosmonic
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two OPFS symlink regression tests to
Browser OPFS filesystem adapterthat weren't covered by the existing suite, ported from scenarios exercised downstream inwasm-web-shell's Playwright tests.Changes
statAtreportssymbolic-link,readlinkAtreturns the missing target,readDirectorylists it, and all of that survives aflush()+ reload through the.__wasi_symlinks__.jsonsidecar.unlinkFileAton a symlink followed by a freshsymlinkAtat the same name round-trips correctly through the sidecar on reload.Both pass against current
main— this is coverage, not a bug fix. Both are non-obvious given the sidecar design:collectSymlinks/injectSymlinksrebuild the map from the tree on every flush, andinjectSymlinksskips any path whose name already exists — exactly the kind of thing that can break silently later.