Skip to content

v1.10.x regression when parsing args of value None #372

Open

Description

@wgreenberg

Seems both v1.10.x releases are raising exceptions when parsing None arguments, whereas previous releases (and argparse itself) handle them fine.

Here's a minimal way to reproduce the issue:

import configargparse
parser = configargparse.ArgParser()
parser.add_argument('--foo')
print(parser.parse_args(['--foo', None]))

Using configargparse==1.9.0, this runs and prints Namespace(foo=None). Using configargparse == 1.10.0 or 1.10.1, we get:

Traceback (most recent call last):                                                                                                                  
  File "/home/willg/dev/techproj/certbot/foo.py", line 5, in <module>                                                                               
    print(parser.parse_args(['--foo', None]))                                                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 1803, in parse_args
    args, argv = self.parse_known_args(                      
                 ^^^^^^^^^^^^^^^^^^^^^^                                                                                                               File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 2042, in parse_known_args
    args, env_var_args_were_added = self._add_args_from_source(
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 1444, in _add_args_from_source    
    self._insert_args_from_config_file_or_env_vars(
  File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 1488, in _insert_args_from_config_file_or_env_va
rs                                                                        
    idx = self._find_insertion_index(args)                          
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 1540, in _find_insertion_index
    end_of_this_parsers_args = self._find_end_of_this_parsers_args(args)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 1759, in _find_end_of_this_parsers_args
    end_of_options_index = self._find_where_args_stop_being_read_as_options(args)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 1744, in _find_where_args_stop_being_read_as_opt
ions                                                                      
    if self._arg_is_an_option_that_takes_every_later_arg(arg):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 1712, in _arg_is_an_option_that_takes_every_late
r_arg                                                                     
    if not self._arg_is_read_as_an_option(arg_string):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/willg/dev/techproj/certbot/venv/lib/python3.11/site-packages/configargparse.py", line 1573, in _arg_is_read_as_an_option
    len(arg_string) > 1
    ^^^^^^^^^^^^^^^
TypeError: object of type 'NoneType' has no len()

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions