Repository navigation
psbt: add support for new Taproot fields - #1847
Conversation
Pull Request Test Coverage Report for Build 2239487179Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
Nice work! Cool to be on the on the bleeding edge when it comes to stuff like this 🤓. Will circle back re testing between hardwarewallets/bitcoind on that lnd PR.
| } | ||
| } | ||
|
|
||
| sort.Sort(TaprootScriptSpendSigSorter(pi.TaprootScriptSpendSig)) |
There was a problem hiding this comment.
Where does the BIP actually mandate that these contents be sorted? Or is this just something we're adding to make testing easier since our serialization would be deterministic-ish?
There was a problem hiding this comment.
The BIP doesn't mention it. I just followed the existing pattern of the library. But I guess it's nice to have things in a stable order? Though since we're not using maps internally but slices, the order should remain stable anyway...
|
Rebased and addressed all comments. |
|
Unit test failure seems to be a flake... Can't reproduce locally. |
|
Kicked things to re-run CI... |
psbt: add support for new Taproot fields
Adds new Taproot specific fields to PSBT as defined in https://github.com/bitcoin/bips/blob/master/bip-0174.mediawiki.
Test vectors taken from bitcoin/bitcoin#22558.