Repository navigation
Conversation
Track input and output callback progress with atomic counters. When input remains active but output callbacks stop for two seconds, rebuild the target IO connection on the control queue and reset buffered timing. Limit reconnect attempts to once every ten seconds and log each attempt. Remove target property listeners during teardown to avoid accumulating registrations across reconnects. Add standalone wake-recovery regression tests so this fix can be reviewed and merged independently of sustained-delay recovery. Copilot-Session: b78a5bb5-6ba7-4a0a-86ac-d87fb6433026
sergiou87
marked this pull request as ready for review
October 26, 2026 13:27
Owner
|
This seems like a decent approach for restarting the driver when it stalls. There's a few changes I think this needs before I can accept it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After waking the display, proxy audio can remain silent until macOS output is switched to another device and back. In one captured failure, Core Audio stopped and restarted the my BenQ's DisplayPort audio engine at display wake, while the proxy remained selected, unmuted, and at the same 48 kHz sample rate. A direct test tone through the BenQ monitor worked, but proxy playback stayed silent.
The exact internal cause was not proven in that running Release build. One recovery gap is that the target's cached started state can remain true across engine restarts, and unchanged device ID/buffer size causes setup to skip rebuilding the connection. Existing timeline recovery cannot help when output callbacks stop arriving.
Changes
Validation
bash tests/run-audio-wake-tests.shMACOSX_DEPLOYMENT_TARGET=12.0override because this Xcode no longer supports the project's 10.11 target. Repository deployment settings are unchanged.Independent of #78: this branch targets
masterand contains only wake recovery. The driver patch is unchanged from the tested combined build; tests and documentation were separated to remove the dependency on the delay fix.