Repository navigation
Conversation
The volume control was applying three compounding transforms instead of one audio taper: - calculateVolumeFactors() used a dB/10 power-ratio exponent instead of the dB/20 amplitude-ratio exponent that applies to PCM samples. - The scalar<->dB getter/setter paths additionally squared or square rooted the value on top of that, so the audible curve was the composition of two mismatched exponential transforms. Fix: remove the extra squaring/sqrt from the four scalar<->dB conversion sites and correct calculateVolumeFactors() to the standard linear-in-dB audio taper (10^(dB/20)), so there is exactly one curve applied end to end. Also widen kVolume_MinDB from -25dB to -40dB to give the taper more usable range at the low end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The volume control was applying three compounding transforms instead of one audio taper:
Fix: remove the extra squaring/sqrt from the four scalar<->dB conversion sites and correct calculateVolumeFactors() to the standard linear-in-dB audio taper (10^(dB/20)), so there is exactly one curve applied end to end. Also widen kVolume_MinDB from -25dB to -40dB to give the taper more usable range at the low end.
Subjectively now the volume slider feels much more "linear" to the ear.