Repository navigation
Add "hide when unavailable" setting to gate PR #61 behavior - #70
Merged
briankendall merged 2 commits intoMay 21, 2026
Merged
Conversation
Addresses reviewer feedback on PR briankendall#61: the auto-hide behavior is useful but should not change the default for existing users who rely on the proxy device as a stable, always-visible target for apps that do not react well to devices appearing and disappearing. * Adds a new persisted preference outputDeviceHideWhenUnavailable, defaulting to false (preserves prior behavior). * Driver only reports kAudioDevicePropertyIsHidden = 1 when the setting is on AND the target device is not ready. * Extracts the repeated PropertiesChanged(kAudioDevicePropertyIsHidden) notification blocks from PR briankendall#61 into a single helper. * Adds a matching checkbox to the Settings app, wired through the same configurator round-trip used by the existing active-condition radios. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
mcg1969
added a commit
to mcg1969/proxy-audio-device
that referenced
this pull request
May 6, 2026
Contributor
Author
Manual verification on macOS 26.2 / Xcode 26.4Completed end-to-end testing with the driver built from this branch and installed at Verified:
Not explicitly tested (taking on faith given code symmetry with the checked-on path):
Happy to run additional scenarios if you'd like, @briankendall. |
Owner
|
This seems to work great! Thanks for the PR! |
5 tasks done
|
@briankendall Would be nice to release a new version for those who are not able to build the current changes on their own. |
Owner
|
@mcg1969 If you wouldn't mind could you give this beta release a try and see if everything is still working? |
Contributor
Author
|
Thanks for the note! I will do that. My custom version has been working really well for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR builds on #61 by @seungwoochoe to address the feedback from @briankendall: the auto-hide behavior is useful but needs to be opt-in so it does not change behavior for existing users who rely on the proxy device as a stable, always-visible target.
Two commits, to keep the two authors' work cleanly separated:
outputDeviceHideWhenUnavailable— defaults tofalse, so behavior matches the current release for anyone who upgrades without opening Settings.Settings app mockup
The new checkbox appears at the bottom of the existing Settings window, unchecked by default:
Note: this is a programmatic mockup rendered from the xib's frame coordinates; native macOS rendering will look tighter (system fonts, bezel gradients, vibrancy). Positions and labels are faithful to what the actual xib produces.
Changes
outputDeviceHideWhenUnavailable, stored viagPlugIn_Host->WriteToStorageas aCFBoolean, following the same pattern asoutputDeviceActiveCondition.kAudioDevicePropertyIsHiddengetter now returns1only when the pref is on AND the target device is not ready — default (off) preserves the prior always-visible behavior.PropertiesChanged(kAudioDevicePropertyIsHidden)notification blocks into a singlenotifyHiddenPropertyChanged()helper.MainMenu.xibextended to accommodate the new control.Rationale for the default
From @briankendall's review on #61:
Defaulting the new pref to
falsepreserves that behavior for existing installations; users who want the new auto-hide behavior can opt in via the Settings app.Test plan
ProxyAudioDevicetarget: succeedsProxy Audio Device Settingstarget: succeedscoreaudiodrestartsDisclosure
This change was developed with assistance from Claude (Anthropic's AI coding assistant). The
Co-Authored-By: Claude Opus 4.7trailer on commit 2 reflects this.