Repository navigation
Conversation
The three arguments had three naming styles from three periods: source, requested_output_channels and task_context. The session and its two builders now take source, outputs and task, and the session has the attributes outputs and task. The declarations on a benchmark and on a subject do not change.
The pins name the tips of the refactor/common-vocabulary branches of unified and core so that the checks run against the four branches together. They are temporary.
The adapter makes, for each requested region in order, the calls of a session for that region alone. A session with behavior and a region is still refused.
in_channels and required_channels replace supported_modalities and required_modalities; policy_in_channels and policy_out_channels replace policy_inputs and policy_outputs. The word modality stays only as an extractor key.
Collaborator
Author
|
retest this please |
A refusal during the run, such as the legacy model refusing behavior with a region in one look_at, now raises with a plain message.
…registers The unified package registers clip-vit-b-32 and qwen2.5-vl-3b, and brainscore.load_model loads those. The copies here were older versions of the same registrations.
The majajhong2015 plugin folder is again as on master. The four -unified identifiers are registered by the unified package, which imports the data, metric and ceiling from this plugin.
A benchmark that left an intervention active was not caught here. The entry point now calls the core release check before it returns.
The task key holds id() of the fitting set. Without a reference, a new set at a freed address could match and skip the legacy refit.
The adapter refuses a session that asks for behavior with a region before any look_at; this is an error of the run, not a declaration mismatch.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
source,outputsandtask.Why
Core and unified now use one vocabulary for sessions, tasks and declarations. This repository follows it, so a vision model runs the same experiments as every other model.
Scores
No score changes. Thirteen model and benchmark pairs gave identical scores on a cloud machine before the last Friends changes. The same check on the final commits is running. Its result will be added to this pull request.
Verification
CI installs core and unified at the branch tips, so the four branches are tested together.
Merge order
Do not merge before the owner approves. The pins in this branch are temporary.