Repository navigation
variants: add dranet to nvidia variants - #4974
Merged
Merged
Conversation
KCSesh
reviewed
Oct 16, 2026
maherthomsi
force-pushed
the
dranet
branch
7 times, most recently
from
October 22, 2026 17:25
955e8d4 to
f0653e8
Compare
maherthomsi
marked this pull request as ready for review
October 22, 2026 17:25
maherthomsi
force-pushed
the
dranet
branch
3 times, most recently
from
October 22, 2026 21:09
ab48b3c to
469d30e
Compare
Pick up settings.kubelet-dra-drivers.net for the dranet service. Signed-off-by: Maher Homsi <maherhom@amazon.com>
maherthomsi
changed the title
maherthomsi
force-pushed
the
dranet
branch
2 times, most recently
from
November 4, 2026 23:39
d8d68f1 to
c0637b3
Compare
Bump the version to 1.69.0 and add an AddPrefixesMigration for the new settings.kubelet-dra-drivers.net settings. Signed-off-by: Maher Homsi <maherhom@amazon.com>
maherthomsi
force-pushed
the
dranet
branch
4 times, most recently
from
November 5, 2026 21:48
b7b4707 to
68be765
Compare
maherthomsi
changed the title
qianxjcraig
reviewed
Nov 6, 2026
Add the dranet host service defaults (rendered ExecStart, the disabled marker, and the settings.kubelet-dra-drivers.net opt-in toggle), symlink them into the aws-k8s-1.34 through aws-k8s-1.37 nvidia variants, and include the dranet package in those variants. Restart the unit with --no-block so that turning the driver on applies without a reboot. Signed-off-by: Maher Homsi <maherhom@amazon.com>
qianxjcraig
approved these changes
Nov 6, 2026
jmt-lab
approved these changes
Nov 6, 2026
KCSesh
reviewed
Nov 6, 2026
| git = "https://github.com/bottlerocket-os/bottlerocket-settings-sdk" | ||
| tag = "bottlerocket-settings-models-v0.29.0" | ||
| version = "0.19.0" | ||
| tag = "bottlerocket-settings-models-v0.31.0" |
Contributor
There was a problem hiding this comment.
This is the wrong setting sdk version
Contributor
|
Fix in: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the bottlerocket-settings-sdk to v0.31.0 and add associated migration tests.
Add the dranet host service defaults, symlink them into the aws-k8s-1.34 through aws-k8s-1.37 nvidia variants, and include the package in those variants.
The defaults set settings.kubelet-dra-drivers.net: enabled, bind-address, and advertised-devices. The service only runs if enabled is true.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.