Show pagination progress dots when fetching all transactions - #7
Merged
Merged
Conversation
When --all is used and stderr is a terminal, print a dot per fetched page so the user gets feedback during long-running fetches. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mrtlopes
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
progress io.Writerparameter toPaginateAllso callers can opt in to progress reporting--allis passed and stderr is a terminal, thetransactionscommand prints a dot per fetched pagenil— no behavior change for themTest plan
bp transactions --allin a terminal and verify dots appear on stderr while pages are fetched, followed by a newlinebp transactions --all 2>/dev/nulland verify no dots appear (non-terminal path)go test ./...bp wallets,bp portfoliostill work normally🤖 Generated with Claude Code