Skip to content

Fix: replace /v1/assets API with /v1/ticker for asset resolution - #2

Merged
mrtlopes merged 2 commits into
mainfrom
fix/use-ticker-instead-of-assets-api
Apr 13, 2026
Merged

mrtlopes merged 2 commits into
mainfrom
fix/use-ticker-instead-of-assets-api

Conversation

@mrtlopes

Copy link
Copy Markdown
Collaborator

Summary

  • The /v1/assets endpoint returns 401 Unauthorized, breaking the trades, portfolio, and prices commands
  • The /v1/ticker endpoint already provides all needed fields (id, name, symbol, type, price) — use it as the single source of truth
  • Adds Name field to TickerEntry and a ByID map to Ticker, so assets can be resolved by ID without the assets API
  • Eliminates N+1 GetAsset calls in prices command, reducing total API calls

@mrtlopes
mrtlopes requested a review from a team April 13, 2026 13:49
The /v1/assets endpoint returns 401, breaking trades, portfolio, and
prices commands. The /v1/ticker endpoint already provides all needed
fields (id, name, symbol, type, price), so use it as the single source
of truth. This eliminates the assets API dependency and reduces the
number of API calls.
@mrtlopes
mrtlopes force-pushed the fix/use-ticker-instead-of-assets-api branch from ab08213 to 4f193b4 Compare April 13, 2026 14:09
No longer needed after replacing /v1/assets with /v1/ticker lookups.
@mrtlopes
mrtlopes merged commit 5a55532 into main Apr 13, 2026
2 checks passed
@mrtlopes
mrtlopes deleted the fix/use-ticker-instead-of-assets-api branch April 14, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants