Skip to content

Avoid unnecessary translations - #297

Merged
hebasto merged 1 commit into
bitcoin-core:masterfrom
hebasto:210425-btc
May 25, 2021
Merged

hebasto merged 1 commit into
bitcoin-core:masterfrom
hebasto:210425-btc

Conversation

@hebasto

@hebasto hebasto commented Apr 25, 2021

Copy link
Copy Markdown
Member

Working on translation, I found these translations introduced in #79, that are unnecessary (assuming the universal nature of the "BTC" string).

@jarolrod jarolrod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 19d51a2

Tested that these are all the occurrences in this file, and cross-checked for any occurrences in other files. We already set the notr attribute in other areas of the code such as coincontroldialog.ui, overviewpage.ui, and sendcoinsdialog.ui.

Furthermore, BTC is treated as a symbol or unit of Bitcoin and is untranslatable by nature.

@Sjors

Sjors commented Apr 29, 2021

Copy link
Copy Markdown
Member

Concept ACK

@hebasto
hebasto requested a review from laanwj May 8, 2021 07:09

@promag promag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@hebasto
hebasto merged commit 3ad1b88 into bitcoin-core:master May 25, 2021
@hebasto
hebasto deleted the 210425-btc branch May 25, 2021 22:43
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 27, 2021
@luke-jr

luke-jr commented Jun 12, 2021

Copy link
Copy Markdown
Contributor

Is it really untranslated? What about languages that don't use the Latin alphabet at all?

@hebasto

hebasto commented Jun 12, 2021

Copy link
Copy Markdown
Member Author

Is it really untranslated? What about languages that don't use the Latin alphabet at all?

For example? (not non-Latin languages, but abbreviated name "BTC" in non-Latin languages)

My three non-Latin languages use "BTC", btw.

@luke-jr

luke-jr commented Jun 12, 2021

Copy link
Copy Markdown
Contributor

I would expect Russian to use a Cyrillic abbreviation? Possibly Chinese and Japanese to get single-character units at some point?

@hebasto

hebasto commented Jun 12, 2021

Copy link
Copy Markdown
Member Author

I would expect Russian to use a Cyrillic abbreviation? Possibly Chinese and Japanese to get single-character units at some point?

I've made a quick re-check of some multi-language online services. All of them use "BTC" in non-Latin languages.

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants