Repository navigation
Enable trezor and keepkey change detection for standard single key ouputs - #211
Merged
Merged
Conversation
Collaborator
|
Is there a way of scraping the simulator screen output to test the change detection? Would be nice to automatically test the change address doesn't appear on the screen. |
Member
Author
It is possible to get the entire raw buffer of the display, but I don't think that is particularly useful. |
instagibbs
reviewed
Aug 19, 2019
|
|
||
| # Add the derivation path for change, but only if there is exactly one derivation path | ||
| psbt_out = tx.outputs[i] | ||
| if len(psbt_out.hd_keypaths) == 1: |
Collaborator
There was a problem hiding this comment.
just noting the ledger detection is more eager, trying any number of hd keypaths that appear to match. We could tighten that logic up in a follow-on PR.
…tputs Enable change detection for p2pkh, p2sh-p2wpk, and p2wpkh on the Trezor and Keepkey
achow101
force-pushed
the
trezor-change
branch
from
August 19, 2019 21:21
36ba0d1 to
3dd66bd
Compare
Collaborator
|
utACK 3dd66bd |
achow101
added a commit
that referenced
this pull request
Aug 20, 2019
…ingle key ouputs 3dd66bd Enable trezor and keepkey change detection for standard single key outputs (Andrew Chow) Pull request description: Enable change detection for p2pkh, p2sh-p2wpk, and p2wpkh on the Trezor and Keepkey Fixes #170 ACKs for top commit: instagibbs: utACK 3dd66bd Tree-SHA512: 0a706be08e32de03a58be052ba5af1fa1e00577f733f01616f31e5c2b0a8a6e634d5c02145d60802a4bff1a9b82d20473a18a59ad3f78497773d99edc0c14f93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable change detection for p2pkh, p2sh-p2wpk, and p2wpkh on the Trezor and Keepkey
Fixes #170