Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the UDP/TCP domain result model additions.
No open issues 🎉
What changed in this PR
本次变更补全开放平台小程序域名结果模型,使调用方能够获取接口返回的 UDP/TCP 合法及不合法域名列表,不改变现有字段和行为。
变更内容:
- 新增四个 UDP/TCP 域名字段及对应的 Gson 映射。
- 新增反序列化测试,验证四个字段的解析结果,并注册到 TestNG 测试套件。
| File | Description |
|---|---|
weixin-java-open/src/test/resources/testng.xml |
将新增测试类加入测试套件。 |
weixin-java-open/src/test/java/me/chanjar/weixin/open/bean/result/WxOpenMaDomainResultTest.java |
验证四个 UDP/TCP 域名字段的反序列化结果。 |
weixin-java-open/src/main/java/me/chanjar/weixin/open/bean/result/WxOpenMaDomainResult.java |
补充 UDP/TCP 合法及不合法域名字段和 JSON 映射。 |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
微信开放平台的小程序服务器域名接口会返回以下 UDP/TCP 相关字段:
udpdomaintcpdomaininvalid_udpdomaininvalid_tcpdomain现有
WxOpenMaDomainResult未定义这些字段,导致调用WxOpenMaService#getDomain等相关方法时无法获取对应数据。本次变更:
WxOpenMaDomainResult补充上述四个字段及 Gson 映射兼容性
仅新增返回字段及对应 getter/setter,不改变现有字段和行为,保持 Java 8 兼容。
验证
执行:
mvn -pl weixin-java-open -am -Dmaven.test.skip=false test