Repository navigation
Reintegrate turn with default ports and support for external certificates - #126
Merged
Merged
Conversation
Collaborator
|
awesome, finally a working turn solution again :) thanks for the PR! |
This was referenced Jun 21, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be reasonable to reintegrate coturn using the default ports (5349) even if this doesn't work for some environments with corporate firewalls. The multiplexing approach for coturn (referenced in #73) was dropped by the jitsi devs. So it seems that currently the choice is between a slightly imperfect coturn setup or none at all.
To allow for more individual setups using a different reverse proxy (nginx, apache), coturn should not depend on the auto HTTPS proxy.