Skip to content

Remove parameters not needed #650

Closed
0 of 1 issue completed
Closed

Description

@ypriverol

Description of feature

The following parameters are not really needed because they are in the SDRF:

  • acquisition_method
  • labelling_type ?
  • enzyme
  • fragment_mass_tolerance
  • fragment_mass_tolerance_unit
  • precursor_mass_tolerance
  • precursor_mass_tolerance_unit
  • fixed_mods
  • variable_mods

@daichengxin @jpfeuffer @timosachsenberg As SDRF becomes easier and more common to annotate, all these parameters can be inferred from the SDRF. I myself have never used any of them. Can you think in others @daichengxin @jpfeuffer. I think we can remove them for the next release. Making sure that they are not present, we throw an error that they need to be specified in the SDRF.

Activity

  1. added this to the Release 1.8.0 milestone on Jan 19, 2026
  2. added a commit that references this issue on Jan 19, 2026
    de3d100
  3. daichengxin commented on Jan 20, 2026

    @daichengxin
    Collaborator

    Nice, That should be it for the redundant parameters.

  4. ypriverol commented on Feb 21, 2026

    @ypriverol
    ContributorAuthor

    I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions