Skip to content

Does not add second enzyme to Comet search #529

Open

Description

@MetteBoge

Description of the bug

My SDRF file has two digestion enzymes (two columns comment[cleavage agent details]). But only one is input in CometAdapter. Implement a --second_enzyme that will take the second one maybe?
Is it Sdrf_parser problem?

Command used and terminal output

Relevant files

No response

System information

No response

Activity

  1. daichengxin commented on May 8, 2025

    @daichengxin
    Collaborator

    Yes, MSGFAdapter and SageAdapter don't support multiple enzymes either, right? @timosachsenberg @ypriverol

  2. ypriverol commented on May 8, 2025

    @ypriverol
    Contributor

    They don't. Actually @MetteBoge if you use Trypsin + Lysc we normally use only Trypsin. We don't support yet multiple enzymes. See issue #79

  3. MetteBoge commented on May 8, 2025

    @MetteBoge
    Author

    I had both columns in the sdrf file but only lys-c was parsed into comet adapter.
    I just read that comet adapter has --second_enzyme option. Is there a reason why it is not supported?

    And does this mean there is no reason to add cleavage agent details in the sdrf file?

  4. MetteBoge commented on May 8, 2025

    @MetteBoge
    Author

    Sorry i did not mean to close issue

  5. ypriverol commented on May 8, 2025

    @ypriverol
    Contributor

    What we are doing in this case is to add the major enzyme basically Trypsin only for now until the pipeline supports multiple enzymes. Then only leave in the SDRF Trypsin,.

  6. jpfeuffer commented on May 8, 2025

    @jpfeuffer
    Collaborator

    @ypriverol I think until we support passing through multiple enzymes, the SDRF parser should combine the enzymes from the SDRF, print a warning and pass only Trypsin to downstream tools.
    Otherwise, all the datasets get annotated wrongly just because multiple enzymes are not supported.

  7. ypriverol commented on May 8, 2025

    @ypriverol
    Contributor

    Actually this is a great idea, @fabianegli or @daichengxin can you update sdrf-pipelines with this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions