You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My SDRF file has two digestion enzymes (two columns comment[cleavage agent details]). But only one is input in CometAdapter. Implement a --second_enzyme that will take the second one maybe?
Is it Sdrf_parser problem?
I had both columns in the sdrf file but only lys-c was parsed into comet adapter.
I just read that comet adapter has --second_enzyme option. Is there a reason why it is not supported?
And does this mean there is no reason to add cleavage agent details in the sdrf file?
What we are doing in this case is to add the major enzyme basically Trypsin only for now until the pipeline supports multiple enzymes. Then only leave in the SDRF Trypsin,.
@ypriverol I think until we support passing through multiple enzymes, the SDRF parser should combine the enzymes from the SDRF, print a warning and pass only Trypsin to downstream tools.
Otherwise, all the datasets get annotated wrongly just because multiple enzymes are not supported.
Activity
daichengxin commentedon May 8, 2025
Yes, MSGFAdapter and SageAdapter don't support multiple enzymes either, right? @timosachsenberg @ypriverol
ypriverol commentedon May 8, 2025
They don't. Actually @MetteBoge if you use Trypsin + Lysc we normally use only Trypsin. We don't support yet multiple enzymes. See issue #79
MetteBoge commentedon May 8, 2025
I had both columns in the sdrf file but only lys-c was parsed into comet adapter.
I just read that comet adapter has --second_enzyme option. Is there a reason why it is not supported?
And does this mean there is no reason to add cleavage agent details in the sdrf file?
MetteBoge commentedon May 8, 2025
Sorry i did not mean to close issue
ypriverol commentedon May 8, 2025
What we are doing in this case is to add the major enzyme basically Trypsin only for now until the pipeline supports multiple enzymes. Then only leave in the SDRF Trypsin,.
jpfeuffer commentedon May 8, 2025
@ypriverol I think until we support passing through multiple enzymes, the SDRF parser should combine the enzymes from the SDRF, print a warning and pass only Trypsin to downstream tools.
Otherwise, all the datasets get annotated wrongly just because multiple enzymes are not supported.
ypriverol commentedon May 8, 2025
Actually this is a great idea, @fabianegli or @daichengxin can you update sdrf-pipelines with this feature.