Skip to content

Harden release follow-ups across data builders and plugin contracts - #428

Merged
enriquea merged 4 commits into
mainfrom
copilot/release-422-review-follow-ups
Oct 7, 2026
Merged

enriquea merged 4 commits into
mainfrom
copilot/release-422-review-follow-ups

Conversation

Copilot AI commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Several builders could silently emit incomplete or mis-keyed data, while plugin round trips could be skipped and Hail checks were absent from fork PRs.

  • PeptideAtlas: Validate required TSV columns; recognize ProForma phospho notation; normalize \N; fail when canonical proteins or phospho sites are absent.
  • pQTL: Resolve outdated symbols through aliases, report unmapped symbols, and cover tissue and p-value filters.
  • COSMIC CGC: Count invalid coordinates, cover legacy headers, handle empty gene mappings, and identify current versus legacy schemas.
  • AlphaGenome: Reject empty alleles, record filter parameters in provenance, support gs:// and hdfs:// inputs, and use hashed duplicate detection with exact collision checks.
  • Plugin contracts and CI: Require non-skipped round-trip tests and run the Hail contract job on pull requests.

Filtered AlphaGenome builds now preserve their options in provenance:

ctx.provenance(
    schema_id="alphagenome-v2",
    build_parameters={
        "output_types": output_types,
        "ontology_curies": ontology_curies,
    },
)

@enriquea
enriquea added this pull request to stack #429 October 7, 2026 08:12
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 14a4087c-28eb-45ff-a9a2-96b7f1389b30

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI linked an issue Oct 7, 2026 that may be closed by this pull request
15 tasks
@codacy-production

codacy-production Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 32 high · 2 medium · 1 minor

Alerts:
⚠ 35 issues (≤ 0 issues of at least minor severity)

Results:
35 new issues

Category Results
Security 32 high
CodeStyle 1 minor
Complexity 2 medium

View in Codacy

🟢 Metrics 111 complexity

Metric Results
Complexity 111

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Base automatically changed from dev to main October 7, 2026 08:26
release: executable contracts for all 26 datasets; AlphaGenome ingests tidy_scores parquet
@enriquea
enriquea force-pushed the copilot/release-422-review-follow-ups branch from d7a5af6 to 6dea6e7 Compare October 7, 2026 08:26
Copilot AI and others added 2 commits October 7, 2026 08:27
Co-authored-by: enriquea <8707954+enriquea@users.noreply.github.com>
Co-authored-by: enriquea <8707954+enriquea@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix PeptideAtlas parsing issues on release #422 Harden release follow-ups across data builders and plugin contracts Oct 7, 2026
Copilot AI requested a review from enriquea October 7, 2026 08:30
@enriquea
enriquea marked this pull request as ready for review October 7, 2026 09:10
@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@enriquea

enriquea commented Oct 7, 2026

Copy link
Copy Markdown
Member

@copilot check why CI workflow are failing. fix!

Co-authored-by: enriquea <8707954+enriquea@users.noreply.github.com>

Copilot AI commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@copilot check why CI workflow are failing. fix!

The CI failures were three test_run_builder_probe_degradation.py cases: Mock DatasetSpecs lacked schema_ids, causing a non-iterable Mock error in the new schema validation. Fixed and pushed as a5c05d6; all four focused tests and blocking lint pass.

@enriquea
enriquea merged commit 4cbc125 into main Oct 7, 2026
15 of 16 checks passed
@enriquea
enriquea deleted the copilot/release-422-review-follow-ups branch October 7, 2026 09:35
enriquea added a commit that referenced this pull request Oct 7, 2026
enriquea added a commit that referenced this pull request Oct 7, 2026
#428 shipped without an entry. Records its user-visible changes and the fixes in #433; the deferred items are in #432.
enriquea added a commit that referenced this pull request Oct 7, 2026
Fixes the findings of the post-merge review of #428 in AlphaGenome, COSMIC CGC, pQTL, PeptideAtlas and core, and adds the CHANGELOG entries #428 lacked. Deferred items are tracked in #432.
enriquea added a commit that referenced this pull request Oct 7, 2026
Docs only: the pQTL examples pass the HGNC lookup table as hgnc_ht, the CHANGELOG entries for #428-#433 are corrected and tidied, and the contributor pages describe schema_ids and the round-trip test rule.
enriquea added a commit that referenced this pull request Oct 7, 2026
Release: PeptideAtlas count fix and the #428 review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release #422 review follow-ups

2 participants