make SignedMailValidator.isValidSignature(X509Certificate cert, SignerInformation signer, List errors) non-static

[ralfhauser]

Hi,

To elegantly inject my own DigestCalculator, this "static" seems to be very unpractical.

https://github.com/bcgit/bc-java/blob/b41f23936724284a20f10dff13c76896a846031b/mail/src/main/java/org/bouncycastle/mail/smime/validator/SignedMailValidator.java#L939C5-L940C6

If not static, I could overwrite it and add my own implementation of JcaSimpleSignerInfoVerifierBuilder.java - or am I missing something ?

[dghgit]

So I think the entry point needs to be on:

    protected void validateSignatures(PKIXParameters pkixParam)

Can you tell me exactly how you would like to construct the SignerInfoVerifier? It's a little tricky with the builders as they're stand alone classes, but we can probably add the necessary parameters to make a call to validateSignature from a sub-class possible.

[ralfhauser]

I did

public static class JcaSimpleSignerInfoVerifierBuilderP
extends JcaSimpleSignerInfoVerifierBuilder {

...

that takes a DigestCalculatorProviderBuilder() I built and uses this in the constructor of the

SignerInformationVerifier

so adding this *ProviderBuilder... as an argument to

 validateSignatures() 

would be helpful.

[dghgit]

Okay, I think I have a solution. The source should appear on github shortly, I've changed the builder and added an extra method to the SignedMailValidator. I've pushed a beta to https://downloads.bouncycastle.org/betas as well, anything dated at or past 10th September has the new classes in it.

Let me know how it goes.

[dghgit]

Fix for this is now in 1.82. Please comment if further changes required or close. Thanks.

[dghgit]

Assumed fixed.