Repository navigation
Remove rust_binary(out_binary=True) hack. - #3891
Merged
Merged
Conversation
rust_shared_library() should be used instead. Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
PiotrSikora
marked this pull request as ready for review
March 7, 2026 07:47
Contributor
Author
|
cc @UebelAndre |
UebelAndre
approved these changes
Mar 7, 2026
UebelAndre
left a comment
UebelAndre
left a comment
Collaborator
There was a problem hiding this comment.
Heck yeah! Thank you so much!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust_shared_library() should be used instead.
closes #3814