Skip to content

feat(pypi): add whl_deps_library repo rule - #3960

Open
aignas wants to merge 11 commits into
bazel-contrib:mainfrom
aignas:aignas.refactor.whl_library_srcs_deps_switch
Open

feat(pypi): add whl_deps_library repo rule#3960
aignas wants to merge 11 commits into
bazel-contrib:mainfrom
aignas:aignas.refactor.whl_library_srcs_deps_switch

Conversation

@aignas

@aignas aignas commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary:

  • Add a new repo rule to just read metadata.json
  • Add integration tests for the repository rules in whl_library.bzl
    file.
  • Make some of the arguments optional in the BUILD.bazel code
    generation.

No changelog, because the rule is not yet exposed to the user in any way.

Split out of #3856
Work towards #2948
Fixes #3071

Summary:
- Add a new repo rule to just read metadata.json
- Add integration tests for the repository rules in `whl_library.bzl`
  file.
- Make some of the arguments optional in the BUILD.bazel code
  generation.

Split out of bazel-contrib#3856
Work towards bazel-contrib#2948
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@aignas

aignas commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

Ran out of time working on this, feel free to hose this with AI tokens if desired.

@aignas
aignas marked this pull request as ready for review July 27, 2026 13:50
@aignas
aignas requested a review from rickeylev as a code owner July 27, 2026 13:50
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

… tests

To prevent test failures across Bazel 7, 8, and 9 where Bzlmod canonical
repository prefixes vary, dynamically parse canonical repository strings by
splitting on '~' and '+'. Also filter out version-dependent toolchain type
targets from dependency comparisons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a test that tests whl_library with an sdist

2 participants