Skip to content

fix(ui): correct light-mode contrast in code hover preview #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
backnotprop merged 1 commit into from
Jun 19, 2026
Merged

fix(ui): correct light-mode contrast in code hover preview #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/editor/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ pre code.hljs .hljs-code {
color: oklch(0.25 0.02 260) !important;
}

/* The code-file hover preview is a <div class="hljs">, so the pre code.hljs
rule above misses it. The unscoped .hljs-* token rules below already color
its tokens; this just supplies the matching default text color. */
.light .code-snippet-preview {
color: oklch(0.25 0.02 260) !important;
}

.light .hljs-keyword,
.light .hljs-selector-tag,
.light .hljs-built_in,
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/components/InlineMarkdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const CodeSnippetPreview: React.FC<{
<span>{filepath.split('/').pop()}</span>
<span className="opacity-60">{lineEnd && lineEnd !== line ? `lines ${line}–${lineEnd}` : `line ${line}`}</span>
</div>
<div className="hljs overflow-auto text-[12px] leading-5 min-h-0" style={{ padding: 0, background: 'var(--color-muted, #1e293b)' }}>
<div className="hljs code-snippet-preview overflow-auto text-[12px] leading-5 min-h-0" style={{ padding: 0, background: 'var(--code-bg, #1e293b)' }}>
<table className="border-collapse w-full">
<tbody>
{snippet.split('\n').map((_, i) => (
Expand Down