Repository navigation
feat(review): accept repository and worktree directory targets - #1644
Merged
backnotprop merged 3 commits intoSep 30, 2026
Merged
Conversation
backnotprop#1483 kept plain positional words tolerated because slash-command hosts (Claude Code, Gemini, Copilot bang prefixes; OpenCode; Pi) forward raw user words verbatim. Directory targets now resolve through resolveReviewTarget, following the annotate tolerant-args precedent: - a sole word, or any path-shaped word (/, ., ~), is a directory candidate; a path-shaped typo or a file still errors - other words are ignored with a notice and the invoking cwd is reviewed as before - a PR/MR URL is found anywhere among the words; two targets error OpenCode: prose keeps the opencode-review command, so it still works on an old binary; the update hint also covers pre-0.27.11 binaries, which answer 'No plan content in hook event'. Tests realpath their tmp roots so they pass on macOS.
backnotprop
added a commit
that referenced
this pull request
Sep 30, 2026
* fix(review): treat path-shaped prose words as prose, not fatal targets #1644 made any path-shaped word a directory target and threw when it did not resolve, so '/plannotator-review review the frontend/backend split' failed. Among several words, a path-shaped word that is missing or a file is now ignored with the usual notice; an existing directory still selects it. A sole argument keeps the strict behavior. OpenCode also toasts a refused review target and the update-CLI hint instead of only logging them. * test(opencode): give the older-CLI bridge test a 20s timeout It now spawns the stub CLI five times and intermittently exceeded bun's 5s default locally.
YeKc1M
pushed a commit
to YeKc1M/plannotator
that referenced
this pull request
Oct 1, 2026
…otprop#1644) * feat(review): accept repository and worktree directory targets * fix(review): keep prose tolerated when review words name no directory backnotprop#1483 kept plain positional words tolerated because slash-command hosts (Claude Code, Gemini, Copilot bang prefixes; OpenCode; Pi) forward raw user words verbatim. Directory targets now resolve through resolveReviewTarget, following the annotate tolerant-args precedent: - a sole word, or any path-shaped word (/, ., ~), is a directory candidate; a path-shaped typo or a file still errors - other words are ignored with a notice and the invoking cwd is reviewed as before - a PR/MR URL is found anywhere among the words; two targets error OpenCode: prose keeps the opencode-review command, so it still works on an old binary; the update hint also covers pre-0.27.11 binaries, which answer 'No plan content in hook event'. Tests realpath their tmp roots so they pass on macOS. --------- Co-authored-by: Michael Ramos <mdramos8@gmail.com>
YeKc1M
pushed a commit
to YeKc1M/plannotator
that referenced
this pull request
Oct 1, 2026
…otprop#1649) * fix(review): treat path-shaped prose words as prose, not fatal targets backnotprop#1644 made any path-shaped word a directory target and threw when it did not resolve, so '/plannotator-review review the frontend/backend split' failed. Among several words, a path-shaped word that is missing or a file is now ignored with the usual notice; an existing directory still selects it. A sole argument keeps the strict behavior. OpenCode also toasts a refused review target and the update-CLI hint instead of only logging them. * test(opencode): give the older-CLI bridge test a 20s timeout It now spawns the stub CLI five times and intermittently exceeded bun's 5s default locally.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
plannotator review [DIRECTORY | PR_URL]and equivalent slash-command support so an agent session can review another repository or worktree without moving the session. A directory inside a repository selects its root; a non-repository parent reuses the existing combined workspace review.The selected directory is passed through discovery, diff generation, repository metadata, and project identity across the CLI, OpenCode, and Pi. Feedback returns to the invoking session and names the directory active at submission, including after a worktree switch. Bare approvals stay unchanged. Host descriptions, skills, and docs describe the new target semantics.
Closes #896. Closes #1482.
Maintainer review
/plannotator-review please review my changesnow errors. Missing directories, file targets, and a directory combined with--patch-filealso fail before discovery rather than opening the caller's repository.opencode-review-directorycommand. Older binaries reject it instead of silently ignoring the target and reviewing the wrong repository; directory reviews therefore require an updated CLI.Verification is strongest on Linux/Git. Native macOS/Windows and live JJ/GitButler/P4 directory workflows remain unverified.