Repository navigation
Add horizontal scroll for diffs with long lines - #1586
Merged
Merged
Conversation
# Conflicts: # packages/review-editor/hooks/usePierreTheme.ts
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge-ready continuation of #1224 by @Karrq.
Opened as a replacement branch because #1224's head branch reports
maintainerCanModify: false, so the prepared merge could not be pushed to thecontributor's own branch. All code in this PR is @Karrq's work — please
attribute the change to them; #1224 should be closed in favour of this PR.
Each file's diff gets its own horizontal scrollbar, pinned to the file header
instead of sitting at the bottom of the file's content where it is off-screen
on any diff taller than the panel.
What this branch adds on top of #1224
mainand resolved the one conflict inpackages/review-editor/hooks/usePierreTheme.ts(the two new[data-code]scrollbar-suppression rules now sit next to main's
.pn-token-hoverrule).bun.lockchanges, which reverted main's dependencyupdates.
bun installagainst main's lockfile produces no diff.packages/core/guide-viewer-manifest.tsfor the viewer build.Verification
bun test packages/review-editor— 321 pass, 0 failDOM_TESTS=1 bun test --isolate packages/review-editor— 550 pass, 0 fail@pierre/diffsrenderer suites — 11 pass, 0 failbun run typecheck— cleanbun run --cwd apps/review build— succeedscheck:manifest— in synccheck:budgets— viewer js 397.9 KB gz (budget 400 KB), css 51.9 KB gz(budget 64 KB)
Closes #1566
Closes #1048