Skip to content

fix(ui): keep image annotation save action visible - #1469

Merged
backnotprop merged 2 commits into
backnotprop:mainfrom
katya4oyu:fix/image-annotator-toolbar-scroll
Sep 20, 2026
Merged

backnotprop merged 2 commits into
backnotprop:mainfrom
katya4oyu:fix/image-annotator-toolbar-scroll

Conversation

@katya4oyu

@katya4oyu katya4oyu commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem

On narrow screens, the image annotation toolbar extends beyond the visible area, making the Save button unreachable.

Change

  • Limit the toolbar to the visible viewport width, including mobile safe areas.
  • Keep the existing controls through Clear in one row and make them horizontally scrollable when they do not fit.
  • Keep the separator and Save button fixed at the right edge.
  • Preserve the existing control order, colors, sizes, and content-sized layout on wider screens.

Verification

  • bun test packages/ui/components/ImageAnnotator
  • DOM_TESTS=1 bun test --isolate packages/ui/components/ImageAnnotator/ImageAnnotator.layout.test.tsx packages/ui/components/ImageAnnotator/ImageAnnotator.shortcuts.test.tsx
  • bun run --cwd packages/ui typecheck
  • bun test packages/ui (784 pass, 574 DOM-gated skips, 0 fail)
  • bun run build:review
  • bun run build:hook
  • git diff --check
  • Verified on physical Mobile Safari that the toolbar is not clipped and Save remains usable.

@katya4oyu
katya4oyu marked this pull request as ready for review September 4, 2026 19:31
@katya4oyu
katya4oyu force-pushed the fix/image-annotator-toolbar-scroll branch from 67f790b to 1156a77 Compare September 9, 2026 02:36
@katya4oyu
katya4oyu force-pushed the fix/image-annotator-toolbar-scroll branch from ecf5e73 to f9c0294 Compare September 19, 2026 02:17
@katya4oyu
katya4oyu force-pushed the fix/image-annotator-toolbar-scroll branch from cee5b59 to ba7fccc Compare September 20, 2026 06:10
@backnotprop
backnotprop merged commit ab18519 into backnotprop:main Sep 20, 2026
24 checks passed
@backnotprop

Copy link
Copy Markdown
Owner

Merged, thanks @katya4oyu. The switch to the existing safe-area overlay class makes the image annotator consistent with the dialogs and composer, and the canvas cap keeps the image clear of the new padding at every width. Ships in the next release.

@katya4oyu

Copy link
Copy Markdown
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants