Repository navigation
feat(opencode): preserve model choice on plan handoff - #1414
Closed
rohanhasabe-esper wants to merge 3 commits into
Closed
rohanhasabe-esper wants to merge 3 commits into
rohanhasabe-esper wants to merge 3 commits into
Conversation
…rent-model preview Compute the session's active model once, up front in submit_plan's execute(), and thread it through both plan-review runtimes (embedded + CLI bridge) into /api/plan. The Approve dropdown now shows the actual model id (e.g. gpt-5.6-terra) instead of the literal string 'current model' when 'Keep current model' is selected, and falls back to the old generic text when the host can't supply it. Also widen the dropdown panel (w-52 -> w-72) so model ids aren't truncated at the edge, per review feedback.
Owner
|
Thanks for digging into this, @rohanhasabe-esper — the underlying complaint was real and it's now fixed on the V2 path: #1569 makes the OpenCode 2 adapter apply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun test apps/opencode-plugin packages/ui packages/editor packages/server apps/hookDOM_TESTS=1 bun test packages/ui/components/HtmlSurfaceControls.test.tsx packages/ui/components/ApproveDropdown.currentModel.test.tsxbunx tsc --noEmit -p packages/ui/tsconfig.jsonbunx tsc --noEmit -p packages/server/tsconfig.jsonbun run --cwd apps/review build && bun run build:hook && bun run build:opencode