fix: Fixing EULA check, relying on HostingEulaUri field#6077
Merged
mohamedzeidan2021 merged 2 commits intoJul 24, 2026
Conversation
mohamedzeidan2021
approved these changes
Jul 23, 2026
mohamedzeidan2021
left a comment
Collaborator
There was a problem hiding this comment.
failing tests unrelated to change
mohamedzeidan2021
temporarily deployed
to
manual-approval
July 23, 2026 17:59 — with
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
manual-approval
July 23, 2026 17:59 — with
GitHub Actions
Inactive
mohamedzeidan2021
temporarily deployed
to
manual-approval
July 23, 2026 17:59 — with
GitHub Actions
Inactive
aviruthen
reviewed
Jul 23, 2026
| if not accept_eula: | ||
| # Only models that declare a hosting EULA (gated models such as | ||
| # Meta Llama) require explicit acceptance. Ungated models | ||
| # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy |
Collaborator
There was a problem hiding this comment.
Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?
Collaborator
|
Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)! |
aviruthen
approved these changes
Jul 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."