fix: dropping jsii.tsc.outDir breaks Java/Go transliteration for jsii-rosetta consumers - #2880
Merged
cdklabs-automation merged 1 commit intoAug 3, 2026
Conversation
cdklabs-automation
enabled auto-merge
August 3, 2026 10:47
mrgrain
marked this pull request as draft
August 3, 2026 10:47
auto-merge was automatically disabled
August 3, 2026 10:47
Pull request was converted to draft
Contributor
Dependency ReviewThe following issues were found:
License Issuesyarn.lock
OpenSSF Scorecard
Scanned Files
|
mrgrain
marked this pull request as ready for review
August 3, 2026 13:51
mrgrain
force-pushed
the
mrgrain/fix/constructs/restore-jsii-tsc-outdir
branch
from
August 3, 2026 13:51
2f2211b to
b63b692
Compare
cdklabs-automation
enabled auto-merge
August 3, 2026 13:56
…-rosetta consumers
10.8.0 replaced `jsii.tsc: { outDir, rootDir }` with `jsii.tsconfig` +
`validateTsconfig` in package.json. Downstream jsii-rosetta consumers
read `jsii.tsc.outDir`/`rootDir` from the published package.json to map
the shipped `lib/*.d.ts` paths back to the `src/` symbol ids recorded in
the assembly. rootDir degrades gracefully via the assembly's
`metadata.tscRootDir`, but outDir has no fallback, so transliteration
silently emits incorrect Java and Go imports.
Restore the `jsii.tsc` block alongside `jsii.tsconfig` via a projen
override, and add a test asserting both fields are present in
package.json.
Fixes #2879
mrgrain
force-pushed
the
mrgrain/fix/constructs/restore-jsii-tsc-outdir
branch
from
August 3, 2026 14:01
b63b692 to
d3249f5
Compare
ShadowCat567
approved these changes
Aug 3, 2026
cdklabs-automation
deleted the
mrgrain/fix/constructs/restore-jsii-tsc-outdir
branch
August 3, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 10.8.0 (since deprecated), any tool using jsii-rosetta to transliterate TypeScript that imports
constructssilently emits broken Java and Go imports:import constructs.Construct;instead ofimport software.constructs.Construct;, and a fabricated Go module path. The assembly loads fine and symbol lookup just degrades, so the bad output looks plausible.10.8.0 replaced
jsii.tsc: { outDir, rootDir }withjsii.tsconfigin package.json. Rosetta needsjsii.tsc.outDirto map the shippedlib/*.d.tsfiles back to thesrc/symbol ids in the assembly, and has no fallback for it (aws/jsii-compiler#2740 tracks that gap). This restores thejsii.tscblock alongsidejsii.tsconfig, and adds a test so a future upgrade cannot silently drop it again.Fixes #2879