fix(auth): improve IdC connection lifespan - #3501
Merged
Merged
Conversation
added 2 commits
May 26, 2023 11:33
justinmk3
approved these changes
May 26, 2023
justinmk3
approved these changes
May 26, 2023
leigaol
pushed a commit
to leigaol/aws-toolkit-vscode
that referenced
this pull request
Jun 13, 2023
Problem: Networking issues cause connections to appear invalidated because we can't refresh the access token. But the refresh token may still be valid. Solution: Assume that the connection is still valid if we see a networking issue. Callers will receive an exception when attempting to fetch a token without an internet connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Networking issues cause connections to appear invalidated because we can't refresh the access token. But the refresh token may still be valid.
Solution
Assume that the connection is still valid if we see a networking issue. Callers will receive an exception when attempting to fetch a token without an internet connection.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.