Repository navigation
feat: generate the hero's Browse buttons from ecosystems.toml - #132
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Marker-driven button generation pages/index.md, scripts/stage.py |
The homepage replaces hard-coded Browse links with a marker. Staging replaces that marker with escaped links for live ecosystems in registry order. It records an error and leaves the page unchanged if the marker does not occur exactly once. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant Registry as ecosystems.toml
participant Stage as scripts/stage.py
participant Page as pages/index.md
Stage->>Registry: Read ecosystem entries
Stage->>Page: Replace hero marker with links for live ecosystems
Possibly related PRs
- awesome-humans/website#129: Adds a Rust Browse button that this change replaces with registry-generated buttons.
Merge Risk: 
Minimal · up to 873c0
-
The homepage Browse links are generated from live registry entries, and staging reports an error if the marker is missing or duplicated. No concrete merge-blocking risk is established.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Description check
-
Explanation
The description explains the change: the hero's Browse buttons now come from ecosystems.toml through a new <!-- ecosystem-buttons --> marker and write_buttons in scripts/stage.py. It covers the live/soon handling, the failure on a missing or duplicate marker, and the verification steps. It also gives the motivation and links issue
#131. It matches the raw summary and the objectives.
Full details: Linked Issues check
-
Explanation
Issue
#131requires generated Browse links in the hero, after “How it works”, for live ecosystems inecosystems.tomlorder.pages/index.mdcontains the single<!-- ecosystem-buttons -->marker in that position.write_buttonsreplaces it with<a class="ah-btn" href="<id>/">Browse <name></a>links, filters forlive, preservesregistry()order, and HTML-escapes names. It records an error when the marker does not occur exactly once, so staging fails for a missing or duplicate marker. No separate automated-test requirement is stated in#131.
Full details: Out of Scope Changes check
-
Explanation
The changes are limited to the home-page marker and the staging code that generates its buttons. The documentation update describes this same staging behaviour. No unrelated change is shown in the reviewed diff.
Full details: Title check
-
Explanation
The title states the main change: the hero's Browse buttons are now generated from ecosystems.toml instead of being maintained by hand. The raw summary and PR objectives confirm this. A new marker in pages/index.md is replaced by write_buttons in scripts/stage.py, with one button per live ecosystem in file order. The title is specific and matches the changeset and the linked issue
#131.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 2
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
What changed
The home page hero's Browse buttons come from
ecosystems.toml.pages/index.mdhas an<!-- ecosystem-buttons -->marker after How it works, andwrite_buttonsinscripts/stage.pyreplaces it with a Browse button for eachliveecosystem, in file order. Asoonecosystem gets no button, because it has no pages to browse. The stage fails if the marker is missing or appears twice, as it does for the cards.Checked with
just checkandjust build: the built hero shows Browse .NET and Browse Rust, as before. Withrustset tosoonlocally, the hero shows only Browse .NET, and the Rust card shows as coming next.Why
The buttons are hard-coded, so each new ecosystem needs one added by hand. Rust went live in #91, which made its card a link, but the hero kept only Browse .NET until #129.
Closes: #131