Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions REVIEW.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Reserve Important for these. Everything else is Nit at most.
- **An unsourced claim.** A new or changed recommendation in `opinions/` or `templates/` that no ID in the file's `sources` carries, or that relies on a link used as a reference to carry it. Quote the claim and name the source IDs the file lists.
- **A misquoted source.** The text says a roster source recommends something that the cited page doesn't say. Quote the sentence from the source, with its link, or don't report it.
- **Guidance from an unvetted source,** folded in instead of proposed through `vet-source`.
- **A rule changed inside a research pull request.** A pull request that adds or changes a topic in `research/` and also changes a rule in `AGENTS.md`, `AWESOME-HUMANS.md`, or a `SKILL.md` that research applies. The rule needs its own pull request, so every open topic can be checked against it.
- **A house opinion out of place.** A `**House:**` rule outside a `/// house | <profile>` block or a `house:<profile>` region, sourced text edited or deleted to make room for a house opinion, or a block whose profile isn't in `sources`.
- **A downgrade.** An example, template pin, or `targets:` value that moves to an older toolchain, edition, or `rust-version` without saying why, or a nightly-only feature presented as the opinion instead of a "Coming next" note.
- **An example that can't build.** A code block or template that wouldn't pass `cargo check` and `cargo clippy` with warnings denied, as `AGENTS.md` runs them, on the declared `targets`. Cite the line and the compiler or lint error you expect.
Expand Down
Loading