Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
## What changed The site's Rust sidebar now leads with Awesome humans, right after the overview, ahead of Opinions. It also gains a Research section after Templates, with an overview and a page per open topic in `research/`. Each topic page carries the same metadata strip as an opinion, without the freshness chip, and opens with a line saying it's unresolved research rather than guidance. `llms.txt` still leaves research out, so agents follow only the opinions. A topic's sidebar label is its title up to the first ": ", without "in Rust" or "for Rust", so "Unsafe: soundness, `unsafe_op_in_unsafe_fn`, and Miri" reads as Unsafe. Its page and the research overview keep the full title. No topic is open on `main` yet, so the section stays hidden until the first research pull request merges, as the other sections do when empty. Checked with `just check`, a new case in the staging test, and a stage of the `research/unsafe` branch with this code. ## Why A reader should meet the people behind the opinions before the opinions themselves. Open research shows what's being worked on and what's blocked on a source, which today is visible only on GitHub. Refs: #23, #24, #25, #26, #27, #28, #29, #30, #31
|
The checks for research are tightening, in awesome-humans/.github#15 (the research template) and #66 (
Written by an agent: Claude Code, Opus 5.5. |
fccd229 to
a63c194
Compare
e858241 to
e05a976
Compare
e05a976 to
c2c4455
Compare
|
Rebased on main after #103 and #104, and fixed the findings from a local review, since CodeRabbit is rate limited:
Not done: retargeting to 1.100. The rest of the repository still targets 1.99, so Written by an agent: Claude Code, Opus 5.5. |
c2c4455 to
0b31710
Compare
Replace "carry" with a precise verb and reword idioms, as docs/tighten-prose does for the other topics. Fix the ten code-review findings: this topic owns the Miri job, the release facts cite the published release notes, a crate with no unsafe adds forbid to its root as ANSSI requires, and four claims that no citable source makes are marked unsupported. Rust Project Goals is flagged as unvetted and listed as a vet-source candidate.
Under #103, #[cfg_attr(miri, ignore)] and the exposed-provenance limit are reference facts from the Miri README. Correct what unsafe_op_in_unsafe_fn requires and which Clippy lints fire on safe code. Keep the unsupported claims out of the opening list, and mark the two that weren't marked: leaving out multiple_unsafe_ops_per_block and workspace deny over forbid, which security.md proposes the other way. Give the example a test, so the Miri pass checks something, and record the compile under it. Note that anssi-rust is scoped to security.md, that cargo-careful needs nightly too, which rust.md rows are new, and that 1.100.0 shipped none of the Coming next features.
Turning on an optional lint is a choice, and only a watch-list source makes it, so the three Clippy safety lints leave the opening list and become the sixth unsupported claim. Name the workspace deny claim the same way everywhere, make the template lints wait for support, and say that a reference fact cites a reference. Scope the Miri README's limit to integer-to-pointer casts and with_exposed_provenance.
0b31710 to
7ec1f9e
Compare
|
A second local review of the 2026-11-14 fix commit found five issues. 7ec1f9e fixes each:
The description's recommendation, proposed outcome, target files, and blockers say the same, and it now counts five decisions for The branch is rebased onto Written by an agent: Claude Code, Fable 5.2. |
Question
What should a Rust developer know and do about
unsafe: soundness,unsafe_op_in_unsafe_fn, and Miri? This is theunsafe.mdtopic inPLAN.md's phase 6. The topic is inresearch/unsafe.md.Recommendation
Add
#![forbid(unsafe_code)]to the root of every crate that has nounsafe, and justify each use in a crate that needs it. Keep each invariant in a private field so the module is the soundness boundary. Document everyunsafewith// SAFETY:and# Safety:missing_safety_docwarns by default for the sections. Turning onundocumented_unsafe_blocksand the twounnecessary_safety_*lints is unsupported. Prefer&rawand the strict provenance APIs, and runcargo miri testin CI. Maturity: GA. Everything recommended is stable in 1.99.1, except Miri andcargo-careful, tools that run only on nightly.Sources
unsafeblocks and functions promise, the definition of soundness, and that no aliasing model is decided: The Rust Reference (citable,rust-docs)Ord: The Rustonomicon (citable,rust-docs)SAFETYcomments, small unsafe blocks, and running Miri on nightly: The Rust Programming Language, chapter 20.1 (citable,rust-docs)unsafe_op_in_unsafe_fnwarns on edition 2024: Rust Edition Guide (citable,rust-docs)forbidversusdenywith#[expect]: Clippy--explain, and the editor's probes on 1.99.1 (citable,rust-docs)&raw,unsafe extern, and unsafe attributes: Rust Blog 1.82 and 1.84, andstd::ptr(citable,rust-blog,rust-docs)MaybeUninitslice methods, and the 1.81 abort on unwind: the published Rust Release Notes (citable,rust-docs)-Zmiri-many-seeds, that a pass isn't a proof, andcargo-careful: Ralf Jung (citable,ralf-jung)matklad)anssi-rust, whose note scopes it tosecurity.md. Only LANG-UNSAFE-ENCP is cross-checked againstrust-docs)corrode)unsafe: Tweede golf (citable,tweede-golf)#[cfg_attr(miri, ignore)], and what Miri misses with exposed provenance: Miri README, with a probe on nightly 2026-10-18 (not on the roster: a reference, for reference facts about the tool)unsafedocumentation: Rust Project Goals 2026 (unvetted)For
resolve-researchProposed outcome: promote, without the six claims the topic marks unsupported unless a citable source turns up for them. Every other recommendation cites a roster source or a reference for a reference fact.
Target files: a new
opinions/unsafe.md, with sections on when to writeunsafe, encapsulation and the module boundary, documentation and the lint table, raw pointers and provenance, FFI, and Miri. README.md's Scope list and layout tree.templates/Cargo.tomlgainsundocumented_unsafe_blocks,unnecessary_safety_comment, andunnecessary_safety_docin[workspace.lints.clippy]once a roster source supports them, and theunsafe_codesetting onceresolve-researchsettles it. The twounnecessary_safety_*lints fire on a// SAFETY:comment or# Safetysection on safe code, in any crate. No template holds a crate root, so theforbidrule goes in the opinion only.Blockers: none for promotion. Five decisions are for
resolve-research:unsafe, which only watch-listms-rust-guidelinesallows, keeping the default aliasing model, the0..16seed range, turning on the three Clippy safety lints, which only watch-listms-rust-guidelinespicks, leaving outmultiple_unsafe_ops_per_block, and a workspacedenyover a workspaceforbid.unsafe_codedesign withsecurity.md, which proposes a workspaceforbid.anssi-rust's scope, or cross-check the FFI rules, LANG-UNSAFE, and the crate-rootforbidagainstrust-docs.cargo-careful, tools that run only on nightly. The freshness rule covers features the code uses, and the code stays on stable.vet-sourcecandidate. Admit it, or name it as a reference, before an opinion's Coming next note cites it.This topic owns the Miri CI job, as the
ci.mdandtesting.mdtopics say, andci.mdsets the workflow rules the job follows. ANSSI's leak rules go tosecurity.md. None of the Coming next features shipped in 1.100.0, checked against the Rust Blog announcement on 2026-11-14. The statuses themselves date from 2026-10-19.Checked
The topic has the metadata
AGENTS.md: Metadatadefines, andjust verifypasses. The links added on 2026-11-12 returned 200 withcurl, because lychee isn't installed locally.CARGO_BUILD_WARNINGS=deny cargo check --all-targetsandCARGO_BUILD_WARNINGS=deny cargo clippy --all-targetson 1.99.1, andcargo +nightly miri testruns the test and passes on nightly 2026-10-18, all on 2026-11-14. It needs no crate beyondstd.cargo-carefulare tools.refresh-rust-versionsto retarget the repository. A second review that day found five more, and each is fixed.