refactor: remove deprecated non-functional network-acl rule flags - #1675
Merged
Merged
Conversation
- Remove the individual rule-configuration flags from `auth0 network-acl create` and `auth0 network-acl update`, deprecated in v1.35.0. - Drop the registerDeprecatedRuleFlags helper and its message constant. - Remove the now-orphaned Flag.Deprecate helper from flags.go. - Interactive prompts are unaffected; they use inline Flag literals and do not depend on the removed flag registrations.
bkiran6398
marked this pull request as ready for review
September 17, 2026 13:23
ramya18101
approved these changes
Sep 17, 2026
ramya18101
deleted the
DXCDT-2385/remove-depricated-flags-network-acl
branch
September 17, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Removes the individual rule-configuration flags from
auth0 network-acl createandauth0 network-acl update.These flags were registered into local variables that were never read, so they had no effect on the created or updated rule. They only added confusion by appearing usable while doing nothing. The
--ruleflag (rule configuration as JSON) was already the only functional non-interactive path and remains unchanged.--action,--redirect-uri,--scope,--asns,--country-codes,--subdivision-codes,--ipv4-cidrs,--ipv6-cidrs,--ja3-fingerprints,--ja4-fingerprints,--user-agents,--auth0-managed.Impact: passing one of the removed flags now returns an unknown flag error instead of being silently ignored.
Configure a rule non-interactively with
--rule:auth0 network-acl create --rule '{"action":{"block":true},"match":{"ipv4_cidrs":["1.2.3.4/32"]},"scope":"authentication"}'📚 References
🔬 Testing
make test-unitpasses.go build ./...andgo vet ./internal/cli/pass.make docsproduces no diff (the flags were hidden, so they were never in the generated reference).auth0 network-acl create/updatewith no flags still launches the interactive prompts unchanged; passing a removed flag returns an unknown flag error.📝 Checklist