Skip to content

refactor: remove deprecated non-functional network-acl rule flags - #1675

Merged
ramya18101 merged 1 commit into
mainfrom
DXCDT-2385/remove-depricated-flags-network-acl
Sep 17, 2026
Merged

ramya18101 merged 1 commit into
mainfrom
DXCDT-2385/remove-depricated-flags-network-acl

Conversation

@bkiran6398

@bkiran6398 bkiran6398 commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

🔧 Changes

Removes the individual rule-configuration flags from auth0 network-acl create and auth0 network-acl update.

These flags were registered into local variables that were never read, so they had no effect on the created or updated rule. They only added confusion by appearing usable while doing nothing. The --rule flag (rule configuration as JSON) was already the only functional non-interactive path and remains unchanged.

  • Removes the flags: --action, --redirect-uri, --scope, --asns, --country-codes, --subdivision-codes, --ipv4-cidrs, --ipv6-cidrs, --ja3-fingerprints, --ja4-fingerprints, --user-agents, --auth0-managed.
  • Removes the now-orphaned deprecation helper.
  • Interactive prompts are unaffected; they never depended on these flags.

Impact: passing one of the removed flags now returns an unknown flag error instead of being silently ignored.

Configure a rule non-interactively with --rule:

auth0 network-acl create --rule '{"action":{"block":true},"match":{"ipv4_cidrs":["1.2.3.4/32"]},"scope":"authentication"}'

📚 References

🔬 Testing

  • make test-unit passes.
  • go build ./... and go vet ./internal/cli/ pass.
  • make docs produces no diff (the flags were hidden, so they were never in the generated reference).
  • Manual: running auth0 network-acl create / update with no flags still launches the interactive prompts unchanged; passing a removed flag returns an unknown flag error.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

- Remove the individual rule-configuration flags from `auth0 network-acl
  create` and `auth0 network-acl update`, deprecated in v1.35.0.
- Drop the registerDeprecatedRuleFlags helper and its message constant.
- Remove the now-orphaned Flag.Deprecate helper from flags.go.
- Interactive prompts are unaffected; they use inline Flag literals and do
  not depend on the removed flag registrations.
@bkiran6398 bkiran6398 changed the title refactor(network-acl)!: remove deprecated rule flags refactor: remove non-functional network-acl rule flags Sep 17, 2026
@bkiran6398 bkiran6398 changed the title refactor: remove non-functional network-acl rule flags refactor: remove deprecated non-functional network-acl rule flags Sep 17, 2026
@bkiran6398
bkiran6398 marked this pull request as ready for review September 17, 2026 13:23
@bkiran6398
bkiran6398 requested a review from a team as a code owner September 17, 2026 13:23
@ramya18101
ramya18101 merged commit a15e941 into main Sep 17, 2026
6 checks passed
@ramya18101
ramya18101 deleted the DXCDT-2385/remove-depricated-flags-network-acl branch September 17, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants