Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

use system $LANG in preference to en_US - #33

Merged
zcbenz merged 3 commits into
atom:masterfrom
OJFord:patch-1
Feb 17, 2016
Merged

zcbenz merged 3 commits into
atom:masterfrom
OJFord:patch-1

Conversation

@OJFord

@OJFord OJFord commented Feb 11, 2016

Copy link
Copy Markdown
Contributor

If $LANG is set, no need to force en_US, even just as a default.

This marginally improves the situation in atom/spell-check#21.

If $LANG is set, no need to force en_US, even just as a default.

This goes some way in improving atom/spell-check experience for non-Americans.
@OJFord

OJFord commented Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

@50Wliu Does this look okay?

It's working great for me locally. Selfishly I'd like to not have it clobbered every update; less selfishly I think having the default be the system default just reduces friction for anyone that happens not to be LANG=en_US :)

@zcbenz

zcbenz commented Feb 17, 2016

Copy link
Copy Markdown
Contributor

Looks good to me.

zcbenz added a commit that referenced this pull request Feb 17, 2016
use system $LANG in preference to en_US
@zcbenz
zcbenz merged commit 5446f12 into atom:master Feb 17, 2016
@OJFord
OJFord deleted the patch-1 branch February 17, 2016 12:34
OJFord added a commit to OJFord/spell-check that referenced this pull request Feb 17, 2016
As of atom/node-spellchecker#33 (v3.2.3), the default language used is that of the `LANG` environment variable. This is an (non-closing) improvement for those subscribed to atom#21.
OJFord added a commit to OJFord/dotfiles that referenced this pull request May 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants