This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
use system $LANG in preference to en_US - #33
Merged
Merged
Conversation
If $LANG is set, no need to force en_US, even just as a default. This goes some way in improving atom/spell-check experience for non-Americans.
Contributor
Author
|
@50Wliu Does this look okay? It's working great for me locally. Selfishly I'd like to not have it clobbered every update; less selfishly I think having the default be the system default just reduces friction for anyone that happens not to be |
Contributor
|
Looks good to me. |
zcbenz
added a commit
that referenced
this pull request
Feb 17, 2016
use system $LANG in preference to en_US
OJFord
added a commit
to OJFord/spell-check
that referenced
this pull request
Feb 17, 2016
As of atom/node-spellchecker#33 (v3.2.3), the default language used is that of the `LANG` environment variable. This is an (non-closing) improvement for those subscribed to atom#21.
OJFord
added a commit
to OJFord/dotfiles
that referenced
this pull request
May 22, 2016
Using `LANG=en_GB` with atom/node-spellchecker#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
$LANGis set, no need to forceen_US, even just as a default.This marginally improves the situation in atom/spell-check#21.