ENH: upgraded allowed TF versions by VincentAuriau · Pull Request #316 · artefactory/choice-learn

VincentAuriau · 2026-04-29T08:41:52Z

No description provided.

gemini-code-assist

Code Review

This pull request updates the dependency versions for TensorFlow and tf_keras in both pyproject.toml and requirements.txt. The reviewer suggests maintaining upper bounds on the TensorFlow version to ensure long-term stability and prevent potential breaking changes from future major releases, providing a specific code suggestion for the pyproject.toml file.

github-actions · 2026-04-29T08:48:46Z

Coverage Report for Python 3.9

File	Stmts	Miss	Cover	Missing
choice_learn
__init__.py	2	0	100%
tf_ops.py	62	1	98%	283
choice_learn/basket_models
__init__.py	4	0	100%
alea_carta.py	148	22	85%	86–90, 92–96, 98–102, 106, 109, 131, 159, 308, 431–455
base_basket_model.py	248	29	88%	115–116, 127, 145, 189, 259, 381, 489, 589–591, 680, 785, 793, 803, 851, 854–864, 925–928, 968–969
basic_attention_model.py	89	4	96%	424, 427, 433, 440
self_attention_model.py	133	9	93%	71, 73, 75, 450–454, 651
shopper.py	184	9	95%	130, 159, 325, 345, 360, 363, 377, 489, 618
choice_learn/basket_models/data
__init__.py	2	0	100%
basket_dataset.py	193	55	72%	74–77, 295–297, 407, 540–576, 604–644, 667, 674–679, 749–760, 808
preprocessing.py	94	78	17%	43–45, 128–364
choice_learn/basket_models/datasets
__init__.py	3	0	100%
badminton.py	81	6	93%	62, 194–199, 247
bakery.py	38	3	92%	47, 51, 61
choice_learn/basket_models/utils
__init__.py	0	0	100%
permutation.py	22	1	95%	37
choice_learn/data
__init__.py	3	0	100%
choice_dataset.py	649	33	95%	198, 250, 283, 421, 463–464, 589, 724, 738, 840, 842, 937, 957–961, 1140, 1159–1161, 1179–1181, 1209, 1214, 1223, 1240, 1281, 1293, 1307, 1346, 1361, 1366, 1395, 1408, 1443–1444
indexer.py	241	23	90%	20, 31, 45, 60–67, 202–204, 219–230, 265, 291, 582
storage.py	161	6	96%	22, 33, 51, 56, 61, 71
store.py	72	72	0%	3–275
choice_learn/datasets
__init__.py	4	0	100%
base.py	400	5	99%	42–43, 153–154, 714
expedia.py	102	83	19%	37–301
tafeng.py	49	0	100%
choice_learn/datasets/data
__init__.py	0	0	100%
choice_learn/models
__init__.py	14	2	86%	15–16
base_model.py	335	34	90%	145, 187, 289, 297, 303, 312, 352, 356–357, 362, 391, 395–396, 413, 426, 434, 475–476, 485–486, 587, 589, 605, 609, 734–735, 935, 939–953
baseline_models.py	49	0	100%
conditional_logit.py	269	26	90%	49, 52, 54, 85, 88, 91–95, 98–102, 136, 206, 212–216, 351, 388, 445, 520–526, 651, 685, 822, 826
halo_mnl.py	124	2	98%	186, 374
latent_class_base_model.py	286	39	86%	55–61, 273–279, 288, 325–330, 497–500, 605, 624, 665–701, 715, 720, 751–752, 774–775, 869–870, 974
latent_class_mnl.py	62	6	90%	257–261, 296
learning_mnl.py	67	3	96%	157, 182, 188
nested_logit.py	291	12	96%	55, 77, 160, 269, 351, 484, 530, 600, 679, 848, 900, 904
reslogit.py	132	7	95%	122, 285, 360, 369, 374, 382, 432
rumnet.py	236	3	99%	748–751, 982
simple_mnl.py	139	6	96%	167, 275, 347, 355, 357, 359
tastenet.py	94	3	97%	142, 180, 188
choice_learn/toolbox
__init__.py	0	0	100%
assortment_optimizer.py	27	6	78%	28–30, 93–95, 160–162
gurobi_opt.py	236	236	0%	3–675
or_tools_opt.py	230	11	95%	103, 107, 296–305, 315, 319, 607, 611
choice_learn/utils
metrics.py	85	64	25%	72–103, 113, 126–130, 147–166, 176, 190–199, 211–232, 242
TOTAL	5660	899	84%

Tests	Skipped	Failures	Errors	Time
222	0 💤	0 ❌	0 🔥	6m 19s ⏱️

github-actions · 2026-04-29T08:49:16Z

Coverage Report for Python 3.10

File	Stmts	Miss	Cover	Missing
choice_learn
__init__.py	2	0	100%
tf_ops.py	62	1	98%	283
choice_learn/basket_models
__init__.py	4	0	100%
alea_carta.py	148	22	85%	86–90, 92–96, 98–102, 106, 109, 131, 159, 308, 431–455
base_basket_model.py	248	29	88%	115–116, 127, 145, 189, 259, 381, 489, 589–591, 680, 785, 793, 803, 851, 854–864, 925–928, 968–969
basic_attention_model.py	89	4	96%	424, 427, 433, 440
self_attention_model.py	133	9	93%	71, 73, 75, 450–454, 651
shopper.py	184	9	95%	130, 159, 325, 345, 360, 363, 377, 489, 618
choice_learn/basket_models/data
__init__.py	2	0	100%
basket_dataset.py	193	55	72%	74–77, 295–297, 407, 540–576, 604–644, 667, 674–679, 749–760, 808
preprocessing.py	94	78	17%	43–45, 128–364
choice_learn/basket_models/datasets
__init__.py	3	0	100%
badminton.py	81	6	93%	62, 194–199, 247
bakery.py	38	3	92%	47, 51, 61
choice_learn/basket_models/utils
__init__.py	0	0	100%
permutation.py	22	1	95%	37
choice_learn/data
__init__.py	3	0	100%
choice_dataset.py	649	33	95%	198, 250, 283, 421, 463–464, 589, 724, 738, 840, 842, 937, 957–961, 1140, 1159–1161, 1179–1181, 1209, 1214, 1223, 1240, 1281, 1293, 1307, 1346, 1361, 1366, 1395, 1408, 1443–1444
indexer.py	241	23	90%	20, 31, 45, 60–67, 202–204, 219–230, 265, 291, 582
storage.py	161	6	96%	22, 33, 51, 56, 61, 71
store.py	72	72	0%	3–275
choice_learn/datasets
__init__.py	4	0	100%
base.py	400	5	99%	42–43, 153–154, 714
expedia.py	102	83	19%	37–301
tafeng.py	49	0	100%
choice_learn/datasets/data
__init__.py	0	0	100%
choice_learn/models
__init__.py	14	2	86%	15–16
base_model.py	335	36	89%	145, 187, 289, 297, 303, 312, 352, 356–357, 362, 391, 395–396, 413, 426, 434, 475–476, 485–486, 587, 589, 605, 609, 611, 734–735, 908, 935, 939–953
baseline_models.py	49	0	100%
conditional_logit.py	269	26	90%	49, 52, 54, 85, 88, 91–95, 98–102, 136, 206, 212–216, 351, 388, 445, 520–526, 651, 685, 822, 826
halo_mnl.py	124	2	98%	186, 374
latent_class_base_model.py	286	39	86%	55–61, 273–279, 288, 325–330, 497–500, 605, 624, 665–701, 715, 720, 751–752, 774–775, 869–870, 974
latent_class_mnl.py	62	6	90%	257–261, 296
learning_mnl.py	67	3	96%	157, 182, 188
nested_logit.py	291	12	96%	55, 77, 160, 269, 351, 484, 530, 600, 679, 848, 900, 904
reslogit.py	132	6	95%	285, 360, 369, 374, 382, 432
rumnet.py	236	3	99%	748–751, 982
simple_mnl.py	139	6	96%	167, 275, 347, 355, 357, 359
tastenet.py	94	3	97%	142, 180, 188
choice_learn/toolbox
__init__.py	0	0	100%
assortment_optimizer.py	27	6	78%	28–30, 93–95, 160–162
gurobi_opt.py	238	238	0%	3–675
or_tools_opt.py	230	11	95%	103, 107, 296–305, 315, 319, 607, 611
choice_learn/utils
metrics.py	85	43	49%	74, 126–130, 147–166, 176, 190–199, 211–232, 242
TOTAL	5662	881	84%

Tests	Skipped	Failures	Errors	Time
222	0 💤	0 ❌	0 🔥	5m 12s ⏱️

github-actions · 2026-04-29T08:49:19Z

Coverage Report for Python 3.12

File	Stmts	Miss	Cover	Missing
choice_learn
__init__.py	2	0	100%
tf_ops.py	62	1	98%	283
choice_learn/basket_models
__init__.py	4	0	100%
alea_carta.py	148	22	85%	86–90, 92–96, 98–102, 106, 109, 131, 159, 308, 431–455
base_basket_model.py	248	29	88%	115–116, 127, 145, 189, 259, 381, 489, 589–591, 680, 785, 793, 803, 851, 854–864, 925–928, 968–969
basic_attention_model.py	89	4	96%	424, 427, 433, 440
self_attention_model.py	133	9	93%	71, 73, 75, 450–454, 651
shopper.py	184	9	95%	130, 159, 325, 345, 360, 363, 377, 489, 618
choice_learn/basket_models/data
__init__.py	2	0	100%
basket_dataset.py	193	55	72%	74–77, 295–297, 407, 540–576, 604–644, 667, 674–679, 749–760, 808
preprocessing.py	94	78	17%	43–45, 128–364
choice_learn/basket_models/datasets
__init__.py	3	0	100%
badminton.py	81	6	93%	62, 194–199, 247
bakery.py	38	3	92%	47, 53, 61
choice_learn/basket_models/utils
__init__.py	0	0	100%
permutation.py	22	1	95%	37
choice_learn/data
__init__.py	3	0	100%
choice_dataset.py	649	33	95%	198, 250, 283, 421, 463–464, 589, 724, 738, 840, 842, 937, 957–961, 1140, 1159–1161, 1179–1181, 1209, 1214, 1223, 1240, 1281, 1293, 1307, 1346, 1361, 1366, 1395, 1408, 1443–1444
indexer.py	241	23	90%	20, 31, 45, 60–67, 202–204, 219–230, 265, 291, 582
storage.py	161	6	96%	22, 33, 51, 56, 61, 71
store.py	72	72	0%	3–275
choice_learn/datasets
__init__.py	4	0	100%
base.py	400	5	99%	42–43, 153–154, 714
expedia.py	102	83	19%	37–301
tafeng.py	49	0	100%
choice_learn/datasets/data
__init__.py	0	0	100%
choice_learn/models
__init__.py	14	2	86%	15–16
base_model.py	335	36	89%	145, 187, 289, 297, 303, 312, 352, 356–357, 362, 391, 395–396, 413, 426, 434, 475–476, 485–486, 587, 589, 605, 609, 611, 734–735, 908, 935, 939–953
baseline_models.py	49	0	100%
conditional_logit.py	269	26	90%	49, 52, 54, 85, 88, 91–95, 98–102, 136, 206, 212–216, 351, 388, 445, 520–526, 651, 685, 822, 826
halo_mnl.py	124	2	98%	186, 374
latent_class_base_model.py	286	39	86%	55–61, 273–279, 288, 325–330, 497–500, 605, 624, 665–701, 715, 720, 751–752, 774–775, 869–870, 974
latent_class_mnl.py	62	6	90%	257–261, 296
learning_mnl.py	67	3	96%	157, 182, 188
nested_logit.py	291	12	96%	55, 77, 160, 269, 351, 484, 530, 600, 679, 848, 900, 904
reslogit.py	132	6	95%	285, 360, 369, 374, 382, 432
rumnet.py	236	3	99%	748–751, 982
simple_mnl.py	139	6	96%	167, 275, 347, 355, 357, 359
tastenet.py	94	3	97%	142, 180, 188
choice_learn/toolbox
__init__.py	0	0	100%
assortment_optimizer.py	27	6	78%	28–30, 93–95, 160–162
gurobi_opt.py	238	238	0%	3–675
or_tools_opt.py	230	11	95%	103, 107, 296–305, 315, 319, 607, 611
choice_learn/utils
metrics.py	85	43	49%	74, 126–130, 147–166, 176, 190–199, 211–232, 242
TOTAL	5662	881	84%

Tests	Skipped	Failures	Errors	Time
222	0 💤	1 ❌	0 🔥	7m 7s ⏱️

github-actions · 2026-04-29T08:49:22Z

Coverage Report for Python 3.11

File	Stmts	Miss	Cover	Missing
choice_learn
__init__.py	2	0	100%
tf_ops.py	62	1	98%	283
choice_learn/basket_models
__init__.py	4	0	100%
alea_carta.py	148	22	85%	86–90, 92–96, 98–102, 106, 109, 131, 159, 308, 431–455
base_basket_model.py	248	29	88%	115–116, 127, 145, 189, 259, 381, 489, 589–591, 680, 785, 793, 803, 851, 854–864, 925–928, 968–969
basic_attention_model.py	89	4	96%	424, 427, 433, 440
self_attention_model.py	133	9	93%	71, 73, 75, 450–454, 651
shopper.py	184	9	95%	130, 159, 325, 345, 360, 363, 377, 489, 618
choice_learn/basket_models/data
__init__.py	2	0	100%
basket_dataset.py	193	55	72%	74–77, 295–297, 407, 540–576, 604–644, 667, 674–679, 749–760, 808
preprocessing.py	94	78	17%	43–45, 128–364
choice_learn/basket_models/datasets
__init__.py	3	0	100%
badminton.py	81	6	93%	62, 194–199, 247
bakery.py	38	3	92%	47, 51, 61
choice_learn/basket_models/utils
__init__.py	0	0	100%
permutation.py	22	1	95%	37
choice_learn/data
__init__.py	3	0	100%
choice_dataset.py	649	33	95%	198, 250, 283, 421, 463–464, 589, 724, 738, 840, 842, 937, 957–961, 1140, 1159–1161, 1179–1181, 1209, 1214, 1223, 1240, 1281, 1293, 1307, 1346, 1361, 1366, 1395, 1408, 1443–1444
indexer.py	241	23	90%	20, 31, 45, 60–67, 202–204, 219–230, 265, 291, 582
storage.py	161	6	96%	22, 33, 51, 56, 61, 71
store.py	72	72	0%	3–275
choice_learn/datasets
__init__.py	4	0	100%
base.py	400	5	99%	42–43, 153–154, 714
expedia.py	102	83	19%	37–301
tafeng.py	49	0	100%
choice_learn/datasets/data
__init__.py	0	0	100%
choice_learn/models
__init__.py	14	2	86%	15–16
base_model.py	335	35	90%	145, 187, 289, 297, 303, 312, 352, 356–357, 362, 391, 395–396, 413, 426, 434, 475–476, 485–486, 587, 589, 605, 609, 611, 734–735, 935, 939–953
baseline_models.py	49	0	100%
conditional_logit.py	269	26	90%	49, 52, 54, 85, 88, 91–95, 98–102, 136, 206, 212–216, 351, 388, 445, 520–526, 651, 685, 822, 826
halo_mnl.py	124	18	85%	186, 341, 360, 364–380
latent_class_base_model.py	286	39	86%	55–61, 273–279, 288, 325–330, 497–500, 605, 624, 665–701, 715, 720, 751–752, 774–775, 869–870, 974
latent_class_mnl.py	62	6	90%	257–261, 296
learning_mnl.py	67	3	96%	157, 182, 188
nested_logit.py	291	12	96%	55, 77, 160, 269, 351, 484, 530, 600, 679, 848, 900, 904
reslogit.py	132	6	95%	285, 360, 369, 374, 382, 432
rumnet.py	236	3	99%	748–751, 982
simple_mnl.py	139	6	96%	167, 275, 347, 355, 357, 359
tastenet.py	94	3	97%	142, 180, 188
choice_learn/toolbox
__init__.py	0	0	100%
assortment_optimizer.py	27	6	78%	28–30, 93–95, 160–162
gurobi_opt.py	238	238	0%	3–675
or_tools_opt.py	230	11	95%	103, 107, 296–305, 315, 319, 607, 611
choice_learn/utils
metrics.py	85	43	49%	74, 126–130, 147–166, 176, 190–199, 211–232, 242
TOTAL	5662	896	84%

Tests	Skipped	Failures	Errors	Time
222	0 💤	1 ❌	0 🔥	6m 38s ⏱️

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

VincentAuriau · 2026-04-30T22:54:20Z

/gemini review

gemini-code-assist

Code Review

This pull request updates the dependency versions for tensorflow, tensorflow-probability, and tf_keras in both pyproject.toml and requirements.txt, introducing environment-specific constraints for Python 3.9 and Python 3.10+. The review feedback highlights critical version incompatibilities between the requested tensorflow and tensorflow-probability versions. Specifically, tensorflow >= 2.18 requires tensorflow-probability >= 0.25, and tensorflow-probability == 0.23 requires at least tensorflow 2.15. It is recommended to align these versions to prevent runtime errors and ensure environment stability.

gemini-code-assist · 2026-04-30T22:55:49Z

+  "tensorflow >=2.18; python_version > '3.9'",
+  "tensorflow <2.16; python_version < '3.10'",
+  "tensorflow-probability >=0.23; python_version > '3.9'",
+  "tensorflow-probability ==0.23; python_version < '3.10'",


The tensorflow-probability (TFP) version is strictly tied to the tensorflow (TF) version.

For Python 3.10+ (where tensorflow >= 2.18 is requested), you should use tensorflow-probability >= 0.25.0. TFP 0.23 is incompatible with TF 2.18 and will likely cause import or runtime errors.

For Python 3.9 (where tensorflow < 2.16 is requested), pinning tensorflow-probability == 0.23 requires tensorflow >= 2.15.0. If the resolver picks an older version like TF 2.14 (which was previously supported), it will fail because TFP 0.23 requires TF 2.15.

It is recommended to align these versions and maintain the previous lower bound for TF on Python 3.9 to ensure compatibility.

Suggested change

"tensorflow >=2.18; python_version > '3.9'",

"tensorflow <2.16; python_version < '3.10'",

"tensorflow-probability >=0.23; python_version > '3.9'",

"tensorflow-probability ==0.23; python_version < '3.10'",

"tensorflow >=2.18; python_version > '3.9'",

"tensorflow >=2.15, <2.16; python_version < '3.10'",

"tensorflow-probability >=0.25; python_version > '3.9'",

"tensorflow-probability ==0.23; python_version < '3.10'",

gemini-code-assist · 2026-04-30T22:55:49Z

+tensorflow>=2.18; python_version > '3.9'
+tensorflow<2.16; python_version < '3.10'
+tensorflow_probability>=0.23; python_version > '3.9'
+tensorflow_probability==0.23; python_version < '3.10'


The tensorflow-probability versions specified here are likely to cause compatibility issues with the requested tensorflow versions.

TF 2.18 (Python 3.10+) requires TFP 0.25.0.

TFP 0.23 (Python 3.9) requires at least TF 2.15.0.

Please align the versions to ensure environment stability and avoid runtime ImportError or version mismatch warnings.

tensorflow>=2.18; python_version > '3.9' tensorflow>=2.15, <2.16; python_version < '3.10' tensorflow_probability>=0.25; python_version > '3.9' tensorflow_probability==0.23; python_version < '3.10'

ENH: upgraded allowed TF versions

b213d20

gemini-code-assist Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread pyproject.toml Outdated

VincentAuriau and others added 3 commits April 29, 2026 10:53

Update pyproject.toml

322ac60

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

update requirements.txt

8aef28f

enh: dependencies version in pyproject.toml

64f1508

gemini-code-assist Bot reviewed Apr 30, 2026

View reviewed changes

VincentAuriau merged commit 30a8438 into main May 1, 2026
8 checks passed

VincentAuriau deleted the update-tf-version branch May 1, 2026 09:38

Navigation Menu

Uh oh!

ENH: upgraded allowed TF versions - #316

ENH: upgraded allowed TF versions#316
VincentAuriau merged 4 commits into
mainfrom
update-tf-version

VincentAuriau commented Apr 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

VincentAuriau commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

VincentAuriau commented Apr 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VincentAuriau commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading