Skip to content

test: use latest regtest master - #888

Merged
Kukks merged 1 commit into
masterfrom
upgrade-regtest
Aug 12, 2026
Merged

Kukks merged 1 commit into
masterfrom
upgrade-regtest

Conversation

@pietro909

@pietro909 pietro909 commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated the internal regression-testing component to a newer version.
    • No user-facing features or behavior changes.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 61c7675c-8568-402f-b7e7-5dfdb219330e

📥 Commits

Reviewing files that changed from the base of the PR and between 142e778 and 85ed090.

📒 Files selected for processing (1)
  • regtest

Walkthrough

The regtest submodule reference changes from commit 7784f5cdf93078c8bf3a2d537c67b4abb12a676c to commit ff5bed3e3a3d94a861addc24a1dad30fa3839cd5.

Changes

regtest submodule update

Layer / File(s) Summary
Update regtest submodule pointer
regtest
The submodule now references commit ff5bed3e3a3d94a861addc24a1dad30fa3839cd5.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bordalix, kukks, sahilc0

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the update to the latest regtest master commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-regtest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 85ed090
Status: ✅  Deploy successful!
Preview URL: https://e2b0dd02.arkade-wallet.pages.dev
Branch Preview URL: https://upgrade-regtest.arkade-wallet.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 85ed090
Status: ✅  Deploy successful!
Preview URL: https://bc2ec986.wallet-bitcoin.pages.dev
Branch Preview URL: https://upgrade-regtest.wallet-bitcoin.pages.dev

View logs

@arkana-ai-bot arkana-ai-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arkana review — regtest submodule bump (7784f5cd → ff5bed3e)

Scope is entirely confined to the regtest dev/CI submodule. No protocol code, no VTXO handling, no signing paths, no wallet logic touched.


What's in the bump (5 commits, PRs #48–#52 in arkade-regtest)

Area Change
Emulator v0.0.5 → v0.0.6 (.env.defaults); compose.ark.yml default also corrected from v0.0.3 → v0.0.6
Fulmine v0.3.25 → v0.4.0-rc.1 (boltz-fulmine service)
Boltz config nonInteractiveClaims = true added
Emulator identity EMULATOR_PUBKEY env var added (derived from the existing deterministic EMULATOR_SECRET_KEY)
New service sync profile: bucket-sync (end-to-end-encrypted KV store) + one-shot bucket-sync-initdb on shared Postgres
CORS BUCKET_SYNC_CORS=* default for local dev; documented override path

Findings

1. Fulmine release-candidate in CI — docker/compose.ark.yml:134

v0.4.0-rc.1 is pinned in the compose default. The boltz e2e suite (src/test/e2e/boltz.test.ts) exercises submarine and reverse swaps against this stack. RCs can carry regressions; if CI starts flaking on the boltz test, this is the first place to look. Low urgency given the retries already in playwright.config.ts, but worth tracking — pin to a stable release when one lands.

2. nonInteractiveClaims = true in boltz config — docker/compose.ark.yml:193

This changes how Boltz claims in regtest. The existing boltz e2e test should cover the happy path, but there's no explicit failure-path test for a non-interactive claim that times out or gets an unexpected VTXO state. Not blocking, but worth a comment in the test file if claim-failure handling is expected to be exercised.

3. bucket-sync-server:latest mutable tag — docker/compose.ark.yml / .env.defaults

The README correctly calls this out and gives the docker pull workaround. The CI workflow exercises the health endpoint and Postgres schema migrations (schema_migrations count check), which is good. The risk is a silent tag update breaking CI before anyone re-pins; a sha-<commit> default in .env.defaults would lock it, but this is a local dev convenience trade-off and the current approach is consistent with how the stack treats other :latest images.

4. Postgres trust auth for bucket-sync — docker/compose.ark.yml:503

ConnectionStrings__Postgres has no password, consistent with the rest of the stack (postgres runs trust auth). Acceptable in a local dev / CI context with no external exposure.

5. Emulator default discrepancy now resolved

The old compose.ark.yml had v0.0.3 as the image fallback while .env.defaults carried v0.0.5. Both now agree on v0.0.6. Good.

6. EMULATOR_PUBKEY addition — .env.defaults

The published hex (02999413…) is the expected public key for the well-known regtest-only deterministic private key (b1c2d3e4…). No key material concern — this key is intentionally shared across projects for test pinning.


Cross-repo impact

No public API, type, proto, or interface changes. Grepped SDK clones (ts, go, rust, dotnet) — no consumers of regtest submodule paths. No cross-repo breakage.


Summary

Clean regtest infra update. The only actionable item worth tracking is the Fulmine RC pin (finding #1); the rest are observations or already-documented trade-offs. No protocol-critical changes.

@pietro909
pietro909 requested a review from bordalix August 10, 2026 07:59
@Kukks
Kukks merged commit 663b8ec into master Aug 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants