Repository navigation
Upgrade ts-sdk 0.4.26 - boltz-swap 0.3.30 - #610
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThis PR updates two Arkade package dependencies in ChangesDependency Version Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ghost
left a comment
There was a problem hiding this comment.
Arkana Review — APPROVE ✅
Scope: Pure dependency bump — @arkade-os/sdk 0.4.25→0.4.26, @arkade-os/boltz-swap 0.3.29→0.3.30. Only package.json and pnpm-lock.yaml touched.
Upstream changes reviewed
ts-sdk 0.4.26 (PRs #484, #485):
- Build tooling fix:
.jsextensions now added to.d.tsdeclaration imports for ESM compat. No runtime change. as constnarrowing onDEFAULT_ARKADE_HRP("ark") andDEFAULT_NETWORK_NAME("bitcoin"). Backwards compatible — narrowsstringto literal type. Wallet doesn't import these directly.VirtualCoininterface: field reorder + comment improvements. No fields added/removed.isSpentdoc now clarifies it's only set for offchain spends (not unrolls/sweeps) — this is a doc-only clarification, not a behavior change.
boltz-swap 0.3.30 (PRs #143, #144):
- Default
referralIdto"arkade-ts-sdk"when not provided in config. Benign behavioral change — wallet doesn't overridereferralId, so it will now send"arkade-ts-sdk"to Boltz. This is intentional tracking, not a security concern. - Bumps its own ts-sdk dep to 0.4.26.
Cross-repo impact
- Wallet uses
ExtendedVirtualCoinfrom SDK, accessingvirtualStatus,spentBy,settledBy,isSpent,value,script. All fields unchanged — only reordered in the interface definition. No breakage. - No public API changes that affect other consumers.
Protocol safety
- No VTXO handling, signing, forfeit, round, or exit path changes.
- No protocol-critical code touched.
CI
- Tests passing. Cloudflare Pages deploys passing.
Clean bump. LGTM.
Summary by CodeRabbit