Repository navigation
Upgrade ts-sdk 0.4.24 - boltz-swap 0.3.27 - #605
Conversation
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying wallet-bitcoin with
|
| Latest commit: |
b5548e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6747c6c5.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://upgrade-ts-sdk-0-4-24-boltz.wallet-bitcoin.pages.dev |
Deploying tmp-boltz-upstream-mainnet-arkade-wallet with
|
| Latest commit: |
b5548e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82db601a.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev |
| Branch Preview URL: | https://upgrade-ts-sdk-0-4-24-boltz.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev |
Deploying wallet-mutinynet with
|
| Latest commit: |
b5548e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6685117.arkade-wallet.pages.dev |
| Branch Preview URL: | https://upgrade-ts-sdk-0-4-24-boltz.arkade-wallet.pages.dev |
ghost
left a comment
There was a problem hiding this comment.
✅ Approved — dependency bump looks correct
What this PR does
Bumps @arkade-os/sdk 0.4.23 → 0.4.24 and @arkade-os/boltz-swap 0.3.26 → 0.3.27. Only package.json and pnpm-lock.yaml are touched. No wallet code changes.
Upstream SDK changes pulled in (ts-sdk v0.4.24)
These are protocol-critical internal changes — not breaking the wallet's public API surface, but worth awareness:
- Unilateral exit bundle (ts-sdk#479) — reworked
unroll.tsandwallet.tsfor batched unilateral exits; newUnrollStep.pkgfield (additive) - VTXO ownership gating (ts-sdk#481) —
filterVtxosForScript()now gates persisted VTXOs by owning script incontractManager.ts, preventing cross-contract address collisions from returning wrong VTXOs - refreshVtxos() fix (ts-sdk#476) — stops forwarding
{ after: undefined, before: undefined }as an explicit window, which was causing unbounded full re-scans with non-advancing cursors - BIP68 timelock refactor (ts-sdk#412) — moved
timelockToSequence/sequenceToTimelocktoutils/timelock.ts(re-exported fromindex.ts, no consumer impact) - VHTLC test fixtures (ts-sdk#138) — test-only
boltz-swap v0.3.27
Only bumps its own @arkade-os/sdk peer dep to 0.4.24. No swap logic changes.
Verification
- ✅ Versions are consistent: boltz-swap 0.3.27 depends on sdk 0.4.24 (confirmed in lockfile snapshot section)
- ✅ Lockfile integrity hashes present and updated
- ✅ No wallet code changes needed — the wallet uses high-level APIs (
getVtxos(),settle(),send(),getAddress(), etc.) whose signatures are unchanged - ✅ Internal SDK functions (
refreshVtxos,unroll,filterVtxosForScript) are not called directly by the wallet - ✅ CI: Cloudflare Pages deploys pass, unit tests pass (one test job still pending at review time)
⚠️ Protocol-critical note
The underlying SDK changes touch VTXO handling, unilateral exit paths, and timelock encoding. These were reviewed and merged in the ts-sdk repo (PRs #412, #476, #479, #481). Recommend smoke-testing unilateral exit and VTXO refresh flows on mutinynet before deploying to mainnet.
LGTM for merge.
No description provided.