Skip to content

Upgrade ts-sdk 0.4.24 - boltz-swap 0.3.27 - #605

Merged
pietro909 merged 1 commit into
masterfrom
upgrade-ts-sdk-0.4.24-boltz-swap-0.3.27
May 6, 2026
Merged

pietro909 merged 1 commit into
masterfrom
upgrade-ts-sdk-0.4.24-boltz-swap-0.3.27

Conversation

@pietro909

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@pietro909 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 42 minutes and 57 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0fe5e7ee-be53-4aa4-a9f9-a93e08cab7b2

📥 Commits

Reviewing files that changed from the base of the PR and between e9471b5 and b5548e4.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-ts-sdk-0.4.24-boltz-swap-0.3.27

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5548e4
Status: ✅  Deploy successful!
Preview URL: https://6747c6c5.wallet-bitcoin.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-24-boltz.wallet-bitcoin.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying tmp-boltz-upstream-mainnet-arkade-wallet with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5548e4
Status: ✅  Deploy successful!
Preview URL: https://82db601a.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-24-boltz.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5548e4
Status: ✅  Deploy successful!
Preview URL: https://b6685117.arkade-wallet.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-24-boltz.arkade-wallet.pages.dev

View logs

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — dependency bump looks correct

What this PR does

Bumps @arkade-os/sdk 0.4.23 → 0.4.24 and @arkade-os/boltz-swap 0.3.26 → 0.3.27. Only package.json and pnpm-lock.yaml are touched. No wallet code changes.

Upstream SDK changes pulled in (ts-sdk v0.4.24)

These are protocol-critical internal changes — not breaking the wallet's public API surface, but worth awareness:

  1. Unilateral exit bundle (ts-sdk#479) — reworked unroll.ts and wallet.ts for batched unilateral exits; new UnrollStep.pkg field (additive)
  2. VTXO ownership gating (ts-sdk#481) — filterVtxosForScript() now gates persisted VTXOs by owning script in contractManager.ts, preventing cross-contract address collisions from returning wrong VTXOs
  3. refreshVtxos() fix (ts-sdk#476) — stops forwarding { after: undefined, before: undefined } as an explicit window, which was causing unbounded full re-scans with non-advancing cursors
  4. BIP68 timelock refactor (ts-sdk#412) — moved timelockToSequence/sequenceToTimelock to utils/timelock.ts (re-exported from index.ts, no consumer impact)
  5. VHTLC test fixtures (ts-sdk#138) — test-only

boltz-swap v0.3.27

Only bumps its own @arkade-os/sdk peer dep to 0.4.24. No swap logic changes.

Verification

  • ✅ Versions are consistent: boltz-swap 0.3.27 depends on sdk 0.4.24 (confirmed in lockfile snapshot section)
  • ✅ Lockfile integrity hashes present and updated
  • ✅ No wallet code changes needed — the wallet uses high-level APIs (getVtxos(), settle(), send(), getAddress(), etc.) whose signatures are unchanged
  • ✅ Internal SDK functions (refreshVtxos, unroll, filterVtxosForScript) are not called directly by the wallet
  • ✅ CI: Cloudflare Pages deploys pass, unit tests pass (one test job still pending at review time)

⚠️ Protocol-critical note

The underlying SDK changes touch VTXO handling, unilateral exit paths, and timelock encoding. These were reviewed and merged in the ts-sdk repo (PRs #412, #476, #479, #481). Recommend smoke-testing unilateral exit and VTXO refresh flows on mutinynet before deploying to mainnet.

LGTM for merge.

@pietro909
pietro909 requested a review from bordalix May 6, 2026 10:12
@pietro909
pietro909 merged commit f39dc1e into master May 6, 2026
6 checks passed
@pietro909
pietro909 deleted the upgrade-ts-sdk-0.4.24-boltz-swap-0.3.27 branch May 6, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants