Skip to content

fix scanner button - #603

Merged
bordalix merged 4 commits into
masterfrom
fix_scanner_button
May 6, 2026
Merged

bordalix merged 4 commits into
masterfrom
fix_scanner_button

Conversation

@bordalix

@bordalix bordalix commented May 4, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #597

Preview:
Screenshot 2026-05-04 at 18 07 39

Summary by CodeRabbit

  • Style
    • Improved label container layout and alignment; inputs inside labels now span available width with refined padding and box-sizing for more consistent sizing.
    • Dark theme: adjusted reminder action button background and text colors for better contrast and readability.

@coderabbitai

coderabbitai Bot commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

Adds a new .label CSS block with positioning and flex layout for internal divs and inputs, and a palette-dark theme override for button.reminder-button.action-sheet-button to adjust background and text colors.

Changes

Form control & theme styling

Layer / File(s) Summary
Layout / Positioning
src/index.css
Introduces .label with position: relative, display: flex, align-items: center, and gap to establish container layout.
Internal element placement
src/index.css
Adds nested .label > div absolute positioning (right-aligned, centered vertically) for overlaid controls.
Input sizing
src/index.css
Adds .label > input rules: width: 100%, padding-right: 36px, and box-sizing: border-box to ensure proper input sizing with overlaid elements.
Theme override
src/index.css
Adds .palette-dark button.reminder-button.action-sheet-button override setting background-color: #222 and `color: `#f7fafc.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • arkanaai
  • pietro909
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix scanner button' is partially related to the changeset, referring to a real aspect of the change but lacks specificity about the actual fix. Consider a more specific title that describes the actual fix, such as 'fix scanner button truncation in recipient field' or 'adjust input sizing to prevent scanner button cutoff'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The code changes to .label styling and input properties directly address the truncation issue by adjusting layout and sizing to ensure the Scan button is fully visible.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the scanner button visibility issue; the palette-dark override is a minor styling adjustment related to button appearance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_scanner_button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/index.css`:
- Line 414: Remove the global fixed width on the shared .input class (the rule
setting width: 40px) and instead allow flexible sizing by deleting that width
and adding min-width: 0 to .input to ensure proper flex-shrink behavior; if a
40px visual is required only for the Send screen, add a scoped selector (e.g.,
.send-recipient-row .input) and place the specialized sizing there so other
forms aren’t affected.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf6de3ed-d801-49c1-a124-98e6cec8dd0d

📥 Commits

Reviewing files that changed from the base of the PR and between 0474193 and 3aa760a.

📒 Files selected for processing (1)
  • src/index.css

Comment thread src/index.css Resolved
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 6, 2026 •

Copy link
Copy Markdown

Deploying tmp-boltz-upstream-mainnet-arkade-wallet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 840338b
Status: ✅  Deploy successful!
Preview URL: https://fb0d2400.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev
Branch Preview URL: https://fix-scanner-button.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev

View logs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 6, 2026 •

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 840338b
Status: ✅  Deploy successful!
Preview URL: https://5952ec62.arkade-wallet.pages.dev
Branch Preview URL: https://fix-scanner-button.arkade-wallet.pages.dev

View logs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 6, 2026 •

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 840338b
Status: ✅  Deploy successful!
Preview URL: https://51c1c96b.wallet-bitcoin.pages.dev
Branch Preview URL: https://fix-scanner-button.wallet-bitcoin.pages.dev

View logs

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/index.css`:
- Around line 431-443: The input's right padding is too small causing overlap
with the absolutely-positioned button group and the selector "& > div" is too
broad; update the InputWithScanner button wrapper to use a specific class (e.g.,
add ".label-actions" to the button container) and replace the broad "& > div"
rule with a targeted ".label-actions" rule, then increase the input padding to
reserve the full action width using a dynamic value such as padding-right:
calc(var(--label-actions-width, 180px)); finally remove the redundant box-sizing
declaration from "& > input" (it's already globally applied) so only the padding
change remains.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3e8a4660-0be1-42ff-abfc-e693b521f306

📥 Commits

Reviewing files that changed from the base of the PR and between 3aa760a and 9485c54.

📒 Files selected for processing (1)
  • src/index.css

Comment thread src/index.css Resolved
@bordalix
bordalix merged commit f10e5c7 into master May 6, 2026
6 checks passed
@bordalix
bordalix deleted the fix_scanner_button branch May 18, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scan (Send screen) button is cut

1 participant