Repository navigation
update regtes images to arkd:v0.9.4 and fulmine:v0.3.21 - #572
Merged
Merged
Conversation
Contributor
WalkthroughUpdates Docker container image version tags in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying tmp-boltz-upstream-mainnet-arkade-wallet with
|
| Latest commit: |
047f02b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d9db2880.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev |
| Branch Preview URL: | https://update-regtest.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev |
Deploying wallet-bitcoin with
|
| Latest commit: |
047f02b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b593548e.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://update-regtest.wallet-bitcoin.pages.dev |
Deploying wallet-mutinynet with
|
| Latest commit: |
047f02b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://be9d2ea5.arkade-wallet.pages.dev |
| Branch Preview URL: | https://update-regtest.arkade-wallet.pages.dev |
ghost
approved these changes
Apr 28, 2026
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
✅ Approved — regtest image bump
Scope: .env.regtest only — bumps arkd v0.9.2→v0.9.4, arkd-wallet v0.9.2→v0.9.4, fulmine v0.3.19→v0.3.21.
Verified
- Versions exist: All three tags confirmed as latest releases on their respective registries.
- CI passing: Cloudflare Pages deploys ✅, test suite ✅.
- No production impact: Changes scoped to
.env.regtest— regtest test environment only. - Wallet SDK compatibility: The wallet uses
@arkade-os/sdk(not raw gRPC), so arkd API changes (pagination onGetVtxos, intent requirement onGetVtxoChain/GetVirtualTxs) are mediated by the SDK layer.
Notable upstream changes picked up
arkd v0.9.3–v0.9.4 includes protocol-relevant fixes:
FinalizeOffchainTx: reject unrolled inputs (arkd#1029)- Reject duplicate boarding inputs (arkd#1021)
- Redis live-store transactional Pop/Delete (arkd#1024)
- Allow unrolled VTXOs to join batches with configurable expiry margin (arkd#961)
- Hardcoded 1-week exit delay on mainnet (arkd#1018) — regtest unaffected
fulmine v0.3.20–v0.3.21: macaroon auth fix for streaming RPCs, go-sdk bump.
FYI — sibling repos are behind
ts-sdk and boltz-swap are still on arkd v0.9.1. Not blocking this PR, but worth tracking separately — especially since boltz-swap pins fulmine to v0.3.15 due to a known balance reporting issue.
LGTM. Ship it.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.env.regtest:
- Around line 2-4: The three image tags in .env.regtest are invalid and will
break regtest; update ARKD_IMAGE and ARKD_WALLET_IMAGE to a known-existing
arkd/wallet tag (use v0.9.3 for both if you intended the source v0.9.3) and set
FULMINE_IMAGE to an existing fulmine tag (v0.3.19), or instead confirm and
replace each ARKD_IMAGE, ARKD_WALLET_IMAGE, and FULMINE_IMAGE with the exact
intended, published tags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit