[bordalix]

NIT: reverse logs in CSV export so newer logs appear on top.

Useful for when Slack shows a preview of the CSV file in support channel.

@tiero wdyt?

Summary by CodeRabbit

• Bug Fixes
  • CSV log export now produces rows in reverse chronological order so exported files list recent entries first (header and column values unchanged).

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c26dbc2f-c40c-4e80-8c65-5133c472ad21

📥 Commits

Reviewing files that changed from the base of the PR and between cad6ba9 and a32eae4.

📒 Files selected for processing (1)

• src/screens/Settings/Logs.tsx

✅ Files skipped from review due to trivial changes (1)

• src/screens/Settings/Logs.tsx

---

Walkthrough

The CSV export in the Logs component now builds the CSV body from a reversed copy of the logs array ([...logs].reverse()), causing exported CSV rows to appear in reverse chronological order; header row generation and per-row value serialization remain unchanged.

Changes

Cohort / File(s)	Summary
CSV Export Logic src/screens/Settings/Logs.tsx	Constructs csvBody from a reversed copy of logs ([...logs].reverse()), reversing the order of exported rows while keeping header and per-row value serialization logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'reverse logs in csv export' directly and accurately describes the main change: reversing the order of logs in the CSV export functionality shown in the raw_summary.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch nit/reverse_logs_csv_file

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cloudflare-workers-and-pages]

Deploying tmp-boltz-upstream-mainnet-arkade-wallet with    Cloudflare Pages

Latest commit:	a32eae4
Status:	✅  Deploy successful!
Preview URL:	https://e56faaa5.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev
Branch Preview URL:	https://nit-reverse-logs-csv-file.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev

View logs

[ghost]

🐛 Bug: .reverse() is on the wrong array

src/screens/Settings/Logs.tsx:112 — The .reverse() is applied to the values within each row, not to the rows themselves. This reverses the column order of the data while the header stays unchanged, producing a malformed CSV.

Current (with this PR applied):

Header:  "msg","time","level"
Row:     "level_val","time_val","msg_val"   ← columns are flipped

The CSV header is built from Object.keys(logs[0]) (line 105) which stays in msg, time, level order. But each row's Object.values(row) is now .reverse()'d, so the data columns no longer match the header.

Intent (from the PR description): reverse row order so newer logs appear first.

Fix — reverse the logs array, not each row's values:

-    const csvBody = logs
+    const csvBody = [...logs].reverse()
       .map((row) =>
         Object.values(row)
           .map((k) => `"${k}"`)
-          .reverse()
           .join(','),
       )
       .join('\n')

Using [...logs].reverse() avoids mutating the React state array.

---

Not protocol-critical — this is a UI-only log export. No security or fund-safety concerns.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/screens/Settings/Logs.tsx (1)

108-115: ⚠️ Potential issue | 🔴 Critical

.reverse() is on the wrong array — breaks CSV column alignment and doesn't reverse log order.

.reverse() is applied to Object.values(row), which flips the column order within each row (e.g., level,time,msg) while csvHeader (Lines 104–107) remains in original key order (msg,time,level). This produces a CSV where headers and values are misaligned — a data-correctness bug for anyone parsing the export.

Additionally, per the PR objective (newer logs at the top so Slack previews show recent entries), the reversal should apply to the outer log list, not to each row's values.

🐛 Proposed fix

-    const csvBody = logs
-      .map((row) =>
-        Object.values(row)
-          .map((k) => `"${k}"`)
-          .reverse()
-          .join(','),
-      )
-      .join('\n')
+    const csvBody = [...logs]
+      .reverse()
+      .map((row) =>
+        Object.values(row)
+          .map((k) => `"${k}"`)
+          .join(','),
+      )
+      .join('\n')

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/screens/Settings/Logs.tsx` around lines 108 - 115, The CSV generation
currently calls .reverse() on Object.values(row), which flips column order and
misaligns values with csvHeader; move the reversal to the outer logs array
instead: iterate over logs.reverse() (or create a reversed copy) when building
csvBody so each row's Object.values(row) stays in the same order as csvHeader
(keep the mapping that wraps values in quotes and joins with commas), and remove
.reverse() from inside the per-row mapping to preserve column alignment while
ensuring newer logs appear at the top.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/screens/Settings/Logs.tsx`:
- Around line 108-115: The CSV generation currently calls .reverse() on
Object.values(row), which flips column order and misaligns values with
csvHeader; move the reversal to the outer logs array instead: iterate over
logs.reverse() (or create a reversed copy) when building csvBody so each row's
Object.values(row) stays in the same order as csvHeader (keep the mapping that
wraps values in quotes and joins with commas), and remove .reverse() from inside
the per-row mapping to preserve column alignment while ensuring newer logs
appear at the top.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b2a6138d-359e-4306-9fd2-ba24e61304bc

📥 Commits

Reviewing files that changed from the base of the PR and between 71606f6 and cad6ba9.

📒 Files selected for processing (1)

• src/screens/Settings/Logs.tsx

[cloudflare-workers-and-pages]

Deploying wallet-bitcoin with    Cloudflare Pages

Latest commit:	a32eae4
Status:	✅  Deploy successful!
Preview URL:	https://47872cc2.wallet-bitcoin.pages.dev
Branch Preview URL:	https://nit-reverse-logs-csv-file.wallet-bitcoin.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying wallet-mutinynet with    Cloudflare Pages

Latest commit:	a32eae4
Status:	✅  Deploy successful!
Preview URL:	https://16322f74.arkade-wallet.pages.dev
Branch Preview URL:	https://nit-reverse-logs-csv-file.arkade-wallet.pages.dev

View logs

[tiero]

ACK

[ghost]

Previous issue resolved ✅

The two follow-up commits correctly:

1. Move .reverse() to operate on the rows array (not column values) — fixes the header/data mismatch
2. Use [...logs].reverse() spread copy to avoid mutating React state in place

LGTM. Clean, minimal change. No protocol impact.