Skip to content

fix lendasat back navigation - #472

Merged
bordalix merged 1 commit into
masterfrom
fix_lendasat_back_nav
Mar 24, 2026
Merged

bordalix merged 1 commit into
masterfrom
fix_lendasat_back_nav

Conversation

@bordalix

@bordalix bordalix commented Mar 24, 2026 •

Copy link
Copy Markdown
Collaborator

Issue:

  • Going to Apps / Lendasat required a double tap on the back button to exit.

Diagnostic:

Solution:

  • The back button on Lendasat does a hard navigate to Apps, thus going back

Summary by CodeRabbit

  • Bug Fixes

    • Back button navigation now properly returns users to the Apps page.
  • Style

    • Minor formatting adjustments.

@coderabbitai

coderabbitai Bot commented Mar 24, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b3f2f21d-46f1-40ad-bccb-aee887f833e1

📥 Commits

Reviewing files that changed from the base of the PR and between 1248fd7 and 7cb67ed.

📒 Files selected for processing (2)
  • src/components/Header.tsx
  • src/screens/Apps/Lendasat/Index.tsx

Walkthrough

Updates the Lendasat app screen to integrate NavigationContext and change the Header back button from default behavior to an explicit callback that navigates to Pages.Apps. A blank line was also added to Header.tsx.

Changes

Cohort / File(s) Summary
Whitespace
src/components/Header.tsx
Added blank line after handleBack assignment.
Navigation Integration
src/screens/Apps/Lendasat/Index.tsx
Imported NavigationContext and Pages, integrated useContext hook to access navigate, and updated Header back prop from boolean flag to explicit callback () => navigate(Pages.Apps).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • bonomat
  • louisinger
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix lendasat back navigation' directly summarizes the main change: fixing the back navigation behavior in the Lendasat component by updating it to perform explicit navigation instead of relying on browser history.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_lendasat_back_nav

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghost

ghost commented Mar 24, 2026

Copy link
Copy Markdown

🔍 Arkana Review — arkade-os/wallet#472

Clean fix. The iframe history conflict diagnosis makes sense — Lendasat's embedded iframe likely pushes its own history entries, making goBack() step into iframe state rather than returning to the Apps screen.

Changes:

  • Header.tsx: Whitespace-only (blank line added) — no functional change
  • Lendasat/Index.tsx: Imports NavigationContext + Pages, passes () => navigate(Pages.Apps) as the back prop instead of the default goBack() behavior

Assessment:

  • ✅ Hard-navigating to Pages.Apps correctly bypasses the stacked iframe history entries
  • ✅ Scoped to Lendasat only — other screens with <Header back /> (boolean) still use the default goBack() flow
  • ✅ Pattern is consistent with how other app screens handle navigation overrides

One note: If other iframe-based apps (Boltz, etc.) exhibit similar double-tap behavior in the future, this same pattern applies — pass an explicit back callback instead of relying on history.

LGTM. No security concerns.

@bordalix
bordalix merged commit 31a724d into master Mar 24, 2026
5 checks passed
@bordalix
bordalix deleted the fix_lendasat_back_nav branch May 18, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants