Skip to content

minor UI fixes - #470

Merged
bordalix merged 1 commit into
masterfrom
minor_ui_fixes
Mar 24, 2026
Merged

bordalix merged 1 commit into
masterfrom
minor_ui_fixes

Conversation

@bordalix

@bordalix bordalix commented Mar 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Style

    • Adjusted padding and spacing throughout list components for improved visual consistency.
    • Refined scroll fade effects on scrollable sections, applying fade masking to specific list views.
  • Bug Fixes

    • Improved scroll behavior and visual feedback on asset lists, swap history, and transaction lists.
  • Documentation

    • Updated Boltz app description to reflect support for Bitcoin swaps alongside existing functionality.

@coderabbitai

coderabbitai Bot commented Mar 24, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d742c7b5-a82e-41a7-bb5a-fac5a61b0659

📥 Commits

Reviewing files that changed from the base of the PR and between c7e2f33 and 3092ecc.

📒 Files selected for processing (13)
  • src/components/Keyboard.tsx
  • src/components/SwapsList.tsx
  • src/components/Text.tsx
  • src/components/TransactionsList.tsx
  • src/index.css
  • src/ionic.css
  • src/screens/Apps/Assets/Detail.tsx
  • src/screens/Apps/Assets/Index.tsx
  • src/screens/Apps/Assets/MintSuccess.tsx
  • src/screens/Apps/Index.tsx
  • src/screens/Settings/Logs.tsx
  • src/screens/Settings/Vtxos.tsx
  • src/screens/Wallet/Receive/QrCode.tsx

Walkthrough

This PR refactors the scroll fade masking system across multiple components. It replaces the no-fade CSS class with a new .scroll-fade class, adjusts padding and spacing in list components, modifies scroll container styling, and updates the Boltz app description text.

Changes

Cohort / File(s) Summary
Scroll fade CSS refactor
src/ionic.css, src/index.css
Changed scroll fade mask logic from ion-content:not(:has(.no-fade)) selector to ion-content:has(.scroll-fade), and added new .scroll-fade class with padding-bottom: 4rem.
Component no-fade class removal
src/components/Keyboard.tsx, src/screens/Apps/Assets/Detail.tsx, src/screens/Apps/Assets/MintSuccess.tsx, src/screens/Wallet/Receive/QrCode.tsx
Removed className='no-fade' from FlexCol wrappers across asset headers, keyboard content, and QR code displays.
Component scroll-fade class addition
src/screens/Apps/Assets/Index.tsx, src/screens/Settings/Logs.tsx, src/screens/Settings/Vtxos.tsx
Added className='scroll-fade' to FlexCol and div containers for asset lists, logs table, and VTXO displays.
List layout restructuring
src/components/SwapsList.tsx, src/components/TransactionsList.tsx
Updated row padding from 0.5rem 1rem to 0.5rem 0, replaced compensating outer wrapper divs with fragments, and added scroll-fade class to scroll containers.
Typography spacing adjustment
src/components/Text.tsx
Changed TextLabel padding from '0.5rem 1rem' to '0 1rem 0.5rem 1rem', adjusting vertical spacing behavior.
Content update
src/screens/Apps/Index.tsx
Updated Boltz app card description from "Arkade and Lightning" to "Arkade, Lightning and Bitcoin".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • pietro909
  • tiero
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'minor UI fixes' is vague and generic, using non-descriptive language that fails to convey specific information about the substantial changes made across multiple components. Consider a more specific title that highlights the primary change, such as 'Replace no-fade CSS class with scroll-fade for improved scroll masking' or 'Refactor CSS scroll styling and adjust UI spacing across components'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch minor_ui_fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3092ecc
Status: ✅  Deploy successful!
Preview URL: https://7fcaba38.wallet-bitcoin.pages.dev
Branch Preview URL: https://minor-ui-fixes.wallet-bitcoin.pages.dev

View logs

@ghost

ghost commented Mar 24, 2026

Copy link
Copy Markdown

Review — minor UI fixes

Clean refactor across 13 files. Two main themes:

1. Scroll fade: opt-out → opt-in
Switches from .no-fade (exclude from fade) to .scroll-fade (include in fade). The ionic.css selector changes from :not(:has(.no-fade)) to :has(.scroll-fade) — more explicit and easier to reason about. Good pattern improvement.

2. List layout cleanup

  • SwapsList / TransactionsList: removes width: calc(100% + 2rem); margin: 0 -1rem negative-margin hack in favor of width: 100% — cleaner.
  • TransactionsList outer wrapper simplified from <div> to <> (fragment).
  • List item padding changed from 0.5rem 1rem to 0.5rem 0 — parent padding now handles horizontal spacing.
  • TextLabel padding adjusted from 0.5rem 1rem to 0 1rem 0.5rem 1rem.

3. Boltz description fix
"Swap instantly between Arkade and Lightning" → "Swap instantly between Arkade, Lightning and Bitcoin" — more accurate since Boltz supports on-chain swaps too.

No functional/security concerns. Straightforward UI polish. ✅

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3092ecc
Status: ✅  Deploy successful!
Preview URL: https://6da59858.arkade-wallet.pages.dev
Branch Preview URL: https://minor-ui-fixes.arkade-wallet.pages.dev

View logs

@bordalix
bordalix merged commit 1248fd7 into master Mar 24, 2026
5 checks passed
@bordalix
bordalix deleted the minor_ui_fixes branch May 18, 2026 16:12
@arkana-ai-bot

Copy link
Copy Markdown
Contributor

Expansion — auto-paginate `indexerProvider.getVtxos` when script count exceeds 1000

Context

When a wallet has a large number of registered scripts (VTXOs, contracts), the indexer query becomes a single unbounded request. The threshold of 1000 scripts is cited in the issue; beyond that a single call risks server-side rejection or timeout.

The SDK already ships PaginationOptions and PageResponse types (@arkade-os/sdk exports bL as PaginationOptions, bK as PageResponse), and RestIndexerProvider is the concrete implementation used by this wallet (src/lib/indexer.ts:1, src/providers/wallet.tsx).

What this needs

When scripts.length > 1000 (or the configured limit), RestIndexerProvider should:

  1. Chunk the script list into batches of ≤ 1000
  2. Issue one request per chunk, using the existing PaginationOptions if available, or plain chunked serial requests if not
  3. Merge the results and return as if it were a single call — the caller should not need to change

Acceptance criteria

  • Calls with ≤ 1000 scripts: behaviour unchanged (no extra requests)
  • Calls with > 1000 scripts: results from all chunks are merged and returned correctly
  • Chunk size is a constant (e.g. MAX_SCRIPTS_PER_REQUEST = 1000) — not a magic literal
  • The default limit is configurable per RestIndexerProvider constructor or globally (so operators with higher limits can opt up)
  • Existing tests pass; add a unit test for the chunking boundary (999 / 1000 / 1001 scripts)

Related files

  • src/lib/indexer.ts — wallet's Indexer wrapper around RestIndexerProvider
  • src/providers/wallet.tsx:859 — where RestIndexerProvider is constructed with the ASP URL
  • @arkade-os/sdk — RestIndexerProvider, PaginationOptions, PageResponse (the change likely needs to land in the SDK first, tracked here for the wallet integration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants