Repository navigation
Upgrade ts sdk 0.4.9 boltz swap 0.3.7 - #450
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughUpdated dependency versions in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Arkana Review — Dependency BumpChanges: Assessment: Clean version bumps, lockfile consistent with specifiers.
No security concerns. Lockfile integrity hashes present and consistent. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 21: Package.json changed dompurify from ^3.2.6 to pinned 3.3.2 which both
removes automatic patch/minor updates and skips the current 3.3.3 release;
because InfoBox (in src/components/AlertBox.tsx) calls DOMPurify.sanitize(html)
you must either restore a permissive range (e.g., ^3.3.3 or >=3.2.6 <4) or
explicitly bump to the latest 3.3.3, then run targeted verification: load
representative PSA HTML cases used by InfoBox and compare sanitized output
before/after the upgrade (pay attention to raw-text/textarea handling and jsdom
parsing changes), update tests or sanitization options if output changed, and
document/approve pinning decision if you intentionally want to lock to a
specific patch.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 09483bd3-7bce-44c9-b678-a010cb4caf33
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
…or change for InfoBox's usage - it calls DOMPurify.sanitize(html) with default options on simple PSA message HTML. The raw-text/textarea parsing fix in 3.3.2 only affects edge cases with <textarea>/<noscript> elements in jsdom environments, not the browser runtime where this PWA runs
Deploying wallet-mutinynet with
|
| Latest commit: |
c6f734d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d696a760.arkade-wallet.pages.dev |
| Branch Preview URL: | https://upgrade-ts-sdk-0-4-9-boltz-s.arkade-wallet.pages.dev |
Deploying wallet-bitcoin with
|
| Latest commit: |
c6f734d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://25aa556d.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://upgrade-ts-sdk-0-4-9-boltz-s.wallet-bitcoin.pages.dev |
🔍 Arkana PR Review — Iterative UpdateScope: 1 new commit ( Assessment✅ No issues. This is a semver range relaxation. The Lockfile is consistent. No functional change to sanitization behavior (the wallet calls Verdict: LGTM — clean dependency update. |
This reverts commit e1bef34.
* Upgrade ts-sdk@0.4.9 and boltz-swap@0.3.7 * Upgrade dompurify - vulnerability * Use semver range, latest update for dompurify. No sanitization behavior change for InfoBox's usage - it calls DOMPurify.sanitize(html) with default options on simple PSA message HTML. The raw-text/textarea parsing fix in 3.3.2 only affects edge cases with <textarea>/<noscript> elements in jsdom environments, not the browser runtime where this PWA runs
Summary by CodeRabbit