Skip to content

Upgrade ts sdk 0.4.9 boltz swap 0.3.7 - #450

Merged
pietro909 merged 3 commits into
masterfrom
upgrade-ts-sdk-0.4.9-boltz-swap-0.3.7
Mar 20, 2026
Merged

pietro909 merged 3 commits into
masterfrom
upgrade-ts-sdk-0.4.9-boltz-swap-0.3.7

Conversation

@pietro909

@pietro909 pietro909 commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated several underlying dependencies to newer versions to improve compatibility, stability, and security of the app.

@coderabbitai

coderabbitai Bot commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d7d7722-c57d-45bc-ae97-d573ab8ff750

📥 Commits

Reviewing files that changed from the base of the PR and between 9a49f89 and c6f734d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

Walkthrough

Updated dependency versions in package.json: @arkade-os/boltz-swap 0.3.5 → 0.3.7, @arkade-os/sdk 0.4.7 → 0.4.9, and dompurify ^3.2.6 → ^3.3.3.

Changes

Cohort / File(s) Summary
Dependency updates
package.json
Bumped @arkade-os/boltz-swap (0.3.5 → 0.3.7), @arkade-os/sdk (0.4.7 → 0.4.9), and dompurify (^3.2.6 → ^3.3.3).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • bordalix
  • Kukks
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically summarizes the main changes: upgrading two key dependencies (@arkade-os/sdk to 0.4.9 and @arkade-os/boltz-swap to 0.3.7), which are the primary focus of this changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-ts-sdk-0.4.9-boltz-swap-0.3.7
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghost

ghost commented Mar 19, 2026

Copy link
Copy Markdown

🔍 Arkana Review — Dependency Bump

Changes: @arkade-os/sdk 0.4.7→0.4.9, @arkade-os/boltz-swap 0.3.5→0.3.7, dompurify 3.3.0→3.3.2

Assessment: Clean version bumps, lockfile consistent with specifiers.

  • sdk 0.4.9 — picks up recent TS SDK work (asset support, fixes from ts-sdk#353–#365)
  • boltz-swap 0.3.7 — aligns with boltz-swap#99/#100 changes
  • dompurify 3.3.2 — pinned (was ^3.2.6), adds engines: {node: ">=20"} constraint; worth noting the pin is intentional vs the previous caret range

No security concerns. Lockfile integrity hashes present and consistent.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 21: Package.json changed dompurify from ^3.2.6 to pinned 3.3.2 which both
removes automatic patch/minor updates and skips the current 3.3.3 release;
because InfoBox (in src/components/AlertBox.tsx) calls DOMPurify.sanitize(html)
you must either restore a permissive range (e.g., ^3.3.3 or >=3.2.6 <4) or
explicitly bump to the latest 3.3.3, then run targeted verification: load
representative PSA HTML cases used by InfoBox and compare sanitized output
before/after the upgrade (pay attention to raw-text/textarea handling and jsdom
parsing changes), update tests or sanitization options if output changed, and
document/approve pinning decision if you intentionally want to lock to a
specific patch.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 09483bd3-7bce-44c9-b678-a010cb4caf33

📥 Commits

Reviewing files that changed from the base of the PR and between da3a767 and 9a49f89.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

Comment thread package.json Resolved
…or change for InfoBox's usage - it calls DOMPurify.sanitize(html) with default options on simple PSA message HTML. The raw-text/textarea parsing fix in 3.3.2 only affects edge cases with <textarea>/<noscript> elements in jsdom environments, not the browser runtime where this PWA runs
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Mar 19, 2026 •

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6f734d
Status: ✅  Deploy successful!
Preview URL: https://d696a760.arkade-wallet.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-9-boltz-s.arkade-wallet.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6f734d
Status: ✅  Deploy successful!
Preview URL: https://25aa556d.wallet-bitcoin.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-9-boltz-s.wallet-bitcoin.pages.dev

View logs

@ghost

ghost commented Mar 19, 2026

Copy link
Copy Markdown

🔍 Arkana PR Review — Iterative Update

Scope: 1 new commit (c6f734de) since last review — switches dompurify specifier from ^3.3.2 to ^3.3.3, resolving to 3.3.3 in the lockfile.

Assessment

✅ No issues. This is a semver range relaxation. The ^3.3.3 specifier still pins to the 3.x line. DOMPurify 3.3.3 contains minor fixes for textarea/noscript edge cases in jsdom environments — not relevant to the browser runtime this PWA uses.

Lockfile is consistent. No functional change to sanitization behavior (the wallet calls DOMPurify.sanitize() with defaults on simple HTML).

Verdict: LGTM — clean dependency update.

@pietro909
pietro909 merged commit e1bef34 into master Mar 20, 2026
5 checks passed
pietro909 added a commit that referenced this pull request Mar 20, 2026
pietro909 added a commit that referenced this pull request Mar 20, 2026
TaprootFreak pushed a commit to TaprootFreak/wallet that referenced this pull request Mar 27, 2026
* Upgrade ts-sdk@0.4.9 and boltz-swap@0.3.7

* Upgrade dompurify - vulnerability

* Use semver range, latest update for dompurify. No sanitization behavior change for InfoBox's usage - it calls DOMPurify.sanitize(html) with default options on simple PSA message HTML. The raw-text/textarea parsing fix in 3.3.2 only affects edge cases with <textarea>/<noscript> elements in jsdom environments, not the browser runtime where this PWA runs
TaprootFreak pushed a commit to TaprootFreak/wallet that referenced this pull request Mar 27, 2026
@bordalix
bordalix deleted the upgrade-ts-sdk-0.4.9-boltz-swap-0.3.7 branch May 18, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants