Repository navigation
Upgrade sdk 0.4.7 - boltz-swap 0.3.5 - #436
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughDependency versions updated in package.json for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying wallet-bitcoin with
|
| Latest commit: |
b2e2fce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d16d91fc.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://upgrade-ts-sdk-0-4-7.wallet-bitcoin.pages.dev |
ghost
left a comment
There was a problem hiding this comment.
🔍 Automated Review — Arkana (PR Reviewer)
PR: Upgrade sdk 0.4.7 / boltz-swap 0.3.5
Scope: Dependency bump — 3 files, +15/-15
Summary
Straightforward dependency version bump:
@arkade-os/sdk0.4.6 → 0.4.7@arkade-os/boltz-swap0.3.4 → 0.3.5- Service worker rebuilt with new SDK
Findings
1. Service worker error filtering (from SDK 0.4.7) — ✅ Good
The VTXO renewal error handler now silences "No VTXOs available to renew" and "is below dust threshold" errors instead of logging them as console.error. These are expected conditions, not actual errors, so this reduces log noise without masking real failures.
2. Version string: -dirty suffix —
- const UN = "5cd4082c"
+ const UN = "0a5ee6f4-dirty"
The bundled service worker version changed to 0a5ee6f4-dirty. The -dirty suffix typically indicates the build was produced from a working tree with uncommitted changes. This is likely harmless (the service worker was probably rebuilt locally before the SDK was published), but worth confirming:
- Was
@arkade-os/sdk@0.4.7published from a clean git state? - If so, the
-dirtytag may just be an artifact of the localwalletbuild process including uncommitted lockfile changes. Not a blocker, but good to understand.
Security
- No key handling, transaction logic, or signing path changes — all changes come from the upstream SDK bump.
- No new dependencies introduced.
- Lock file integrity hashes updated consistently.
Verdict
No blocking issues. Clean dependency bump. The -dirty version tag is the only thing worth a quick sanity check.
Deploying wallet-mutinynet with
|
| Latest commit: |
b2e2fce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b1bb60d.arkade-wallet.pages.dev |
| Branch Preview URL: | https://upgrade-ts-sdk-0-4-7.arkade-wallet.pages.dev |
Summary by CodeRabbit
Bug Fixes
Chores