Skip to content

Upgrade sdk 0.4.7 - boltz-swap 0.3.5 - #436

Merged
pietro909 merged 1 commit into
masterfrom
upgrade-ts-sdk-0.4.7
Mar 16, 2026
Merged

pietro909 merged 1 commit into
masterfrom
upgrade-ts-sdk-0.4.7

Conversation

@pietro909

@pietro909 pietro909 commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Improved error logging for wallet renewal operations by suppressing non-critical error messages.
  • Chores

    • Updated internal dependencies to latest minor versions.

@pietro909
pietro909 requested review from Kukks and louisinger March 16, 2026 12:40
@coderabbitai

coderabbitai Bot commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e818a664-66f6-48b9-9ddf-987900a230d5

📥 Commits

Reviewing files that changed from the base of the PR and between 63e7544 and b2e2fce.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • public/wallet-service-worker.mjs

Walkthrough

Dependency versions updated in package.json for @arkade-os/boltz-swap and @arkade-os/sdk. Error logging suppressed in wallet service worker for specific VTXO renewal messages. Public constant UN value updated.

Changes

Cohort / File(s) Summary
Dependency Updates
package.json
Bumped @arkade-os/boltz-swap from 0.3.4 to 0.3.5 and @arkade-os/sdk from 0.4.6 to 0.4.7.
Error Handling & Constants
public/wallet-service-worker.mjs
Suppressed logging for specific VTXO renewal errors (messages containing "No VTXOs available to renew" or "is below dust threshold"). Updated public constant UN from "5cd4082c" to "0a5ee6f4-dirty".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Kukks
  • bordalix
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main changes—upgrading @arkade-os/sdk to 0.4.7 and @arkade-os/boltz-swap to 0.3.5, which are the primary modifications in package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade-ts-sdk-0.4.7
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2e2fce
Status: ✅  Deploy successful!
Preview URL: https://d16d91fc.wallet-bitcoin.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-7.wallet-bitcoin.pages.dev

View logs

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Automated Review — Arkana (PR Reviewer)

PR: Upgrade sdk 0.4.7 / boltz-swap 0.3.5
Scope: Dependency bump — 3 files, +15/-15

Summary

Straightforward dependency version bump:

  • @arkade-os/sdk 0.4.6 → 0.4.7
  • @arkade-os/boltz-swap 0.3.4 → 0.3.5
  • Service worker rebuilt with new SDK

Findings

1. Service worker error filtering (from SDK 0.4.7) — ✅ Good
The VTXO renewal error handler now silences "No VTXOs available to renew" and "is below dust threshold" errors instead of logging them as console.error. These are expected conditions, not actual errors, so this reduces log noise without masking real failures.

2. Version string: -dirty suffix — ⚠️ Minor concern

- const UN = "5cd4082c"
+ const UN = "0a5ee6f4-dirty"

The bundled service worker version changed to 0a5ee6f4-dirty. The -dirty suffix typically indicates the build was produced from a working tree with uncommitted changes. This is likely harmless (the service worker was probably rebuilt locally before the SDK was published), but worth confirming:

  • Was @arkade-os/sdk@0.4.7 published from a clean git state?
  • If so, the -dirty tag may just be an artifact of the local wallet build process including uncommitted lockfile changes. Not a blocker, but good to understand.

Security

  • No key handling, transaction logic, or signing path changes — all changes come from the upstream SDK bump.
  • No new dependencies introduced.
  • Lock file integrity hashes updated consistently.

Verdict

No blocking issues. Clean dependency bump. The -dirty version tag is the only thing worth a quick sanity check.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2e2fce
Status: ✅  Deploy successful!
Preview URL: https://0b1bb60d.arkade-wallet.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-7.arkade-wallet.pages.dev

View logs

@pietro909
pietro909 merged commit 5ca474d into master Mar 16, 2026
5 checks passed
@pietro909
pietro909 deleted the upgrade-ts-sdk-0.4.7 branch March 16, 2026 13:38
TaprootFreak pushed a commit to TaprootFreak/wallet that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant