Skip to content

fix bug where was not possible to navigate to password in lock wallet - #419

Merged
bordalix merged 1 commit into
masterfrom
fix_lock_wallet
Mar 13, 2026
Merged

bordalix merged 1 commit into
masterfrom
fix_lock_wallet

Conversation

@bordalix

@bordalix bordalix commented Mar 13, 2026 •

Copy link
Copy Markdown
Collaborator

@pietro909 please review

Summary by CodeRabbit

  • Bug Fixes

    • Removed automatic navigation after setting a password in the Lock settings screen, allowing users to remain on the configuration page.
  • Chores

    • Updated internal version identifier.

@coderabbitai

coderabbitai Bot commented Mar 13, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 00af50ae-29bc-4941-bd33-ea8c4f2bfc3e

📥 Commits

Reviewing files that changed from the base of the PR and between 513f822 and a2b1c77.

📒 Files selected for processing (2)
  • public/wallet-service-worker.mjs
  • src/screens/Settings/Lock.tsx
💤 Files with no reviewable changes (1)
  • src/screens/Settings/Lock.tsx

Walkthrough

Two minor changes across separate modules: a constant value update in the wallet service worker and removal of a navigation side effect following password configuration in the Settings Lock screen.

Changes

Cohort / File(s) Summary
Wallet Service Worker
public/wallet-service-worker.mjs
Updated top-level constant xN value from "fda01a1c-dirty" to "513f822a-dirty".
Settings Lock Screen
src/screens/Settings/Lock.tsx
Removed navigation action to Settings page that previously occurred after password option was set in handleSetPassword.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main bug fix: removing a navigation side effect that was preventing users from setting passwords in the lock wallet flow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_lock_wallet
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: a2b1c77
Status: ✅  Deploy successful!
Preview URL: https://fa202a06.wallet-bitcoin.pages.dev
Branch Preview URL: https://fix-lock-wallet.wallet-bitcoin.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: a2b1c77
Status: ✅  Deploy successful!
Preview URL: https://204df5ae.arkade-wallet.pages.dev
Branch Preview URL: https://fix-lock-wallet.arkade-wallet.pages.dev

View logs

@pietro909 pietro909 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@bordalix
bordalix merged commit 9b21e8b into master Mar 13, 2026
4 of 5 checks passed
Kukks added a commit that referenced this pull request Mar 13, 2026
Merge master into wt-navbar-redesign-20260226, incorporating:
- nak version fix (#420)
- password navigation fix (#419)
- chain swaps restore (#415)
- asset avatar UI fixes (#414)
- approved asset icons (#416)
@bordalix
bordalix deleted the fix_lock_wallet branch May 18, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants