Repository navigation
fix sending to onchain address when having assets - #406
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying wallet-bitcoin with
|
| Latest commit: |
d97146b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f52f6e04.wallet-bitcoin.pages.dev |
| Branch Preview URL: | https://fix-send-form-with-onchain-a.wallet-bitcoin.pages.dev |
Deploying wallet-mutinynet with
|
| Latest commit: |
d97146b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3aa82f44.arkade-wallet.pages.dev |
| Branch Preview URL: | https://fix-send-form-with-onchain-a.arkade-wallet.pages.dev |
pietro909
added a commit
that referenced
this pull request
Mar 12, 2026
* Use next branches * Implements chain swaps * fixes * Use new SDK storage * Update integration to Contract Manager * App starting, payments received * Use correct import * Use new SDK storage * wip * SW working * using ws * Latest SDK * workaround for build * Fix build * Rollback unneeeded changes, clean up code * Address Rabbit comment * Set flag in unsub * Fix tx history rendering issue * Update package.json, lock file, worker * Run migration only if needed * Update lock and worker * Use next releases * Clear setInterval on re-init to prevent leaking duplicate intervals * Implements delegators UI (#319) * implements delegators UI * rabbit fixes * dumb down + rename to delegates * revert changes * add unit tests * add e2e test * rabbit fixes * fixes * Upgrade latest sdk * fixes * Ignore md helpers * Stop pinging wallet when locked * Allow the page to force activation of a newly installed worker. * Handle failure in getCommitmentTxIds * Add defensive parsing of messages for stale service workers * Upgrade sdk and boltz-swap * fix Indexer constructor in wallet provider * Use event.waitUntil * update dependencies * bug fix * update dependencies * default delegator * fix URL * delegator * make delegator URL configurable * Wire up delegates * Centralize compressed-xonly conversion, hook in delegates * Trigger reload on delegate on/off * Delegates on by default * Use persisted preference for delegates * Fix type in wallet * Remove workspace file * Fix formatting * Enforce use of delegate upon restore * Use correct delegates port, update e2e test * Remove log * Update Fulmine 0.3.15 and port mapping * Change fulmine port in setup script * fix server persistency * Use delegate url from network * Remove unused VITE_DELEGATOR_URL * fix delegate server * feat: asset support (#318) * Add assets integration design document Design for integrating Arkade SDK asset system (ts-sdk PR #279) into the wallet, covering import, receive, send, mint, reissue, and burn flows. * Add assets integration implementation plan 16-task step-by-step plan covering SDK install, types, providers, navigation, BIP21, all asset screens, send/receive modifications, and tx history updates. * feat: upgrade @arkade-os/sdk to 0.3.13 Upgrade from 0.3.12 to 0.3.13, the latest published version. The asset branch (github:arkade-os/ts-sdk#asset) does not exist yet, so using the latest npm release as the foundation for asset integration. * feat: add asset types and importedAssets to config * feat: add asset flow state to FlowContext * feat: add asset balances and metadata cache to WalletContext * feat: register asset pages in navigation with placeholders * feat: add BIP21 asset URI encoding and decoding * feat: add Assets app card to Apps index * feat: implement Assets list screen * feat: implement asset import screen * feat: implement asset detail screen * feat: implement mint and mint success screens * feat: implement reissue and burn screens * feat: add asset support to receive flow * feat: add asset support to send flow * feat: show asset info in transaction history and coin control * refactor: replace as-any casts with proper SDK types * feat: install @arkade-os/sdk from asset branch (louisinger/wallet-sdk#asset) * refactor: use proper SDK types for transaction assets ArkTransaction now includes assets field from SDK changes, removing the last as-any cast in asp.ts. * chore: gitignore docs/plans * format + ts-sdk from gh repo * allow build * remove useless tests * fixes * fixes * UI fixes * bump ts-sdk * feat(mint): add optional control asset selector Generated with Claude Code via Happy Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> * fix: display asset amounts with proper decimals and convert unit inputs to raw - Add formatAssetAmount utility for raw→human-readable display - Convert user-entered units to raw integers in Burn, Reissue, and Send flows - Apply decimal formatting across all asset display surfaces Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> * style: fix prettier formatting in Burn and Reissue Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> * refactor: address code review issues across asset feature - Skip BTC limits for asset receives in Amount screen - Fix test mocks with missing context properties - Format raw supply display in MintSuccess and Detail screens - Type assetMetadataCache as Map<string, AssetDetails> instead of any - Extract shared assetInputStyle to src/lib/styles.ts - Extract AssetAvatar component to deduplicate avatar pattern (~10 locations) - Fix stale closure in Detail.tsx useEffect - Format asset amounts in Vtxos debug view with metadata lookup - Fix default decimals from 0 to 8 in MintSuccess - Fix Burn placeholder to show formatted balance Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> * fix: apply decimal unit conversion to all asset amount inputs and displays - Add formatAssetAmount() to format.ts for display (raw → human units) - Mint: convert user units to raw via Decimal.mul(amount, 10^decimals) - Send form: convert input to raw, display available balance in units - Burn: convert input to raw, show balance in human-readable units - Reissue: convert input to raw using decimals metadata - All display locations (tx list, asset list, detail, send confirm/success) now apply formatAssetAmount to show correct decimal representation - No trailing zeros thanks to Intl.NumberFormat maximumFractionDigits Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> * persist asset metada * clean * various UI fixes * add playwright tests * fix asset e2e tests * fixes * fix invoice bip21 encoding * fix Apps/Asset/receive * simplify asset import * UI fix + reuse Input component * Merge remote-tracking branch origin/master into assets * Show asset ticker instead of SATS on InputAmount component when receiving an asset * Also fix amount when user has Fiat Only on Settings / Display Preferences * revert changes to InputWithScanner * new InputAssetId component * dry code * tests for lib/assets * Mint: hide dropdown if knownAsset.length <= 0 * allow to mint control asset * feat: add isIssuance helper to detect issuance txs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: show issuance label and green assets in tx list Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: show issuance direction and positive asset amounts in tx detail Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: add issuance transaction rendering test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add burn tx handling, remove asset prefix, move asset icon right - Add isBurn helper (self-send with amount=0 and negative asset amounts) - Update isIssuance to check for positive asset amounts - Remove +/- prefix from asset display (SDK now returns signed amounts) - Show "Burn" label and direction for burn transactions - Move asset icon to right side of amount in tx list Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * handle Issuance and Burn tx in transaction history * Fix restoration * fix test * fix mint tests * update to latest ts-sdk master * fix playwright tests * not:cloned-input selector * verified | approved asset flow * playwright: use reduced motion * move upgrade logic to updateConfig * simplify mint form * fix send all btc * remove ctrlDecimals * remove fuji app * show asset amount in Receive/Success * receive/success fix * rework receive/success * flxShrink mint form * add link to Asset app * add assets settings to toggle service + hide assets in send if inactive (#353) * add assets settings to toggle service + hide assets in send if inactive * nit: 'enabled' instead of 'connected' * add test + fix tests * update boltz config * fixes * fix: revert boltz config and add missing enableAssets in reissue test - Revert [[currencies.lnds]] back to [currencies.lnd] in boltz TOML config. The array syntax broke Boltz's LND connection, causing all Lightning swap e2e tests to fail. - Add missing enableAssets() call to the reissue test, which was omitted when asset toggle support was added in ea958fd. * fix: increase timeout for multi-swap e2e tests The restore and nostr swap tests perform multiple swap operations (reverse + submarine) plus wallet restore, exceeding the default 30s test timeout. Increase to 90s to give these complex flows enough time. * fix: increase action timeout and add balance wait for swap tests The submarine swap creation is async and can take variable time, especially after a reverse swap. Increase actionTimeout from 30s to 60s to accommodate slow swap creation, and add test.setTimeout(120s) for multi-swap tests. Also verify wallet balance is visible before attempting the send flow in the restore test. * fix: revert actionTimeout to 30s and verify balance in nostr test Increasing actionTimeout to 60s made the nostr swap test worse by keeping failed swap connections alive longer, preventing retries from getting a clean Boltz state. Revert to 30s and ensure balance is verified by exact match before submarine swap. * chore: retrigger CI * ci: trigger workflows for PRs targeting next branch * fix: revert Boltz LND config to singular [currencies.lnd] format The boltz/boltz:ark image does not support the plural [[currencies.lnds]] array syntax. This broke all Lightning swap tests (receive, send, refund). Keep pull_policy: always to ensure fresh images. * chore: retrigger CI * fix: fund Boltz core wallet for chain swaps in regtest setup The ARK-to-BTC chain swap direction requires Boltz to have BTC in its core Bitcoin wallet. Without funding, createArkToBtcSwap hangs/fails, breaking "send to onchain address" and "send to onchain via swap" tests. * chore: format setup.mjs * fix: create Bitcoin Core 'core' wallet before funding for Boltz chain swaps * fix: create and fund Boltz core wallet before Boltz starts Move wallet creation before Boltz backend startup so the wallet exists and has funds when Boltz initializes. Mine an extra block to confirm. * fix: fall back to collaborative exit when chain swap creation fails When createArkToBtcSwap returns null or throws, navigate to SendDetails without a pendingSwap. The Details page already handles this case by using collaborativeExitWithFees as the fallback for BTC address sends. * revert: remove Boltz wallet funding from setup (breaks Boltz startup) The wallet funding caused Boltz to fail to start. Instead, the Form.tsx fallback to collaborative exit handles onchain sends when chain swaps are unavailable. * fix: update onchain send test assertions for collaborative exit fees The chain swap path (Boltz ARK→BTC) is unavailable in regtest, so the app falls back to collaborative exit. This changes the fee from 275 (Boltz swap fee) to 200 (ASP onchain output fee from fees intent). Also makes fees intent/clear calls synchronous to prevent race conditions. * fix: remove unused exec import from send test * fix: disable delegate in e2e tests (no delegator service in CI) The delegate feature defaults to true but requires a delegator service at localhost:7004. Since CI has no delegator, wallet initialization hangs causing all tests to timeout. Use VITE_DELEGATE_ENABLED=false in the Playwright config to disable delegation in the test environment. * chore: format all files with prettier after merge * ci: add workflow_dispatch trigger to enable manual CI runs * fix: enable fulmine delegator and fix port mapping for e2e tests - Add FULMINE_DELEGATOR_ENABLED=true and FULMINE_DELEGATOR_FEE=350 - Fix port mapping to expose delegator on port 7002 - Aligns fulmine config with next branch * fix server persistency --------- Co-authored-by: louisinger <louis@vulpem.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Happy <yesreply@happy.engineering> Co-authored-by: João Bordalo <bordalix@users.noreply.github.com> * Delete data on IndexedDB when reset (#366) * fix delegate dev server * fix tests * update dependencies * Use mutinynet server for testing * Fix setup 7001 * E2E fixes, config, delegates url (#369) * Fix e2e delegate test * Log commit from SW to verify updates * Ensure config has all the expected fields * Fix delegates url resolution * Missing type, harden config parsing * reduce tests waiting for maybeLater * skip swap restore test * disable chain swap on receive * Upgrade SDK, boltz, use 30s ServiceWorker timeout (#371) * SDK Version next 8 * Use SW custom timeout * Update SW * Use sdk 0.4.0 and boltz-swap 0.3.0 * Update service worker * Update service worker 2 * fix receive fractional assets (#373) * fix receive fractional assets * fix bip21 in asset receive * disable mint if balance < dust * New asset card (#374) * New asset card * lint * General fixes (#382) * dry code * remove console.log * fix throw with fractional sats * refactor Asset send input amount * fix keyboard to work with assets * Add vmempool.space explorer links for offchain txs and assets (#380) * Add vmempool.space explorer links for offchain txs and assets - Add vmempool.space URL configuration with VITE_VMEMPOOL_URL env var - Add helper functions for offchain tx and asset URLs in explorers.ts - Update Table component to support clickable rows with onClick handlers - Update Details component to accept wallet, assetId, and isOffchainTx props - Make Transaction ID and Asset ID fields clickable in transaction details - Open offchain txs (redeemTxid) in vmempool.space - Open onchain txs (boardingTxid) in mempool.space - Open assets in vmempool.space asset explorer - Only show vmempool links for mainnet by default (configurable via env var) * fix: keep tap-to-copy, add external link icon for explorer links * fix: add aria-label to ExternalLinkIcon, hide link when URL unavailable * fixes --------- Co-authored-by: OpenClaw Agent <agent@openclaw.dev> Co-authored-by: louisinger <louisinger@protonmail.com> Co-authored-by: João Bordalo <bordalix@users.noreply.github.com> * fix max button with large amounts * fix issuing of assets with new control asset * Replace sleep with wait for new vtxo * fix input amount * Don't block app on swap init error (#383) * Don't block the UX if swaps service isn't available and log errors * Update SW * Add tests * Add tests * lint * fix nostr backup of swaps * fix SVGs * fix boltz env * fix tests * lint * fix tests * remove console.log * update pnpm-lock * refactor: simplify Hero component and remove LearnMore section (#395) * fix(pwa): fix swipe-back navigation for iOS standalone mode The iOS edge-swipe gesture was broken in the PWA: it navigated to wrong screens, activated when it shouldn't (showing white pages), and caused double animations. This was due to browser history entries being out of sync with internal navigation state. Replaces the old push-every-navigation model with 1:1 browser history sync — browser entries only exist when there's real back navigation. When the back stack is empty, iOS disables the swipe gesture entirely. Key changes: - navigation.tsx: stable popstate handler via refs (no phantom entries), root navigations clear browser history via history.go(-n), forward navigations push 1:1 to browser history - options.tsx: Settings sub-navigation now pushes browser history entries so swipe-back works within Settings pages, coordinates with main nav via subNavHandler for cleanup on tab switches - Distinguishes swipe vs back-button via isButtonBack flag to suppress Framer Motion animation on swipe (browser already animated it) - Adds overscroll-behavior: none to prevent rubber-banding Note: this is a pragmatic PWA workaround — relies on browser history depth controlling iOS gesture activation. Will be properly solved when migrating to Capacitor (native WKWebView has no Safari gestures). * fix(nav): address CodeRabbit review feedback - Pop blocked entries (InitConnect/Loading) from backStack to prevent infinite loop when user repeatedly presses back - Guard historyDepth from going negative in Settings sub-navigation * fix(nav): address second round of CodeRabbit feedback - goBack delegates to subNavHandler when main backStack is empty - navigateToOption resets historyDepth when returning to Menu * update ts-sdk dependency * fix double swap when claiming reverse swap * fix(ui): match iOS/Android status bar color to app theme (#334) * fix(ui): match iOS/Android status bar color to app theme The status bar stayed white in dark mode because: - The theme-color meta tag was hardcoded to #000000 - Safari doesn't reliably support media queries on theme-color - The html element had no background-color, so the safe area defaulted to white Fix: inline script in <head> reads the stored theme from localStorage and sets theme-color + ion-palette-dark class before first paint. applyTheme() keeps it in sync on manual toggle. Root element background now follows --ion-background-color so the safe area fills correctly. * fix(ui): add dev-only logging to theme bootstrap catch block Address CodeRabbit nitpick: log theme init failures on localhost so broken localStorage/config parsing is visible during development. * fix(ios): status bar color matching and content overlap for iOS 26+ PWA iOS 26+ ignores the theme-color meta tag — it derives the status bar color from the actual rendered content at the top of the page. Add a position:fixed body::before pseudo-element that sits behind the transparent status bar and uses var(--ion-background-color), so iOS samples the correct theme color instantly on theme switch. Push .ion-page below the safe area with top: env(safe-area-inset-top) using ion-app > .ion-page selector (higher specificity than Ionic's core .ion-page { top: 0 } which loads later in the cascade). Also fix manifest.json theme_color (#fff) and improve inline theme bootstrap comments in index.html. * style: fix prettier formatting in ionic.css * fix(ui): match theme enum casing in bootstrap script The Themes enum uses capitalized values ('Dark', 'Light', 'Auto') but the inline bootstrap script compared against lowercase. This caused the dark-mode flash prevention to fail when theme was explicitly set. Also makes the iOS status bar comment version-agnostic per review. --------- Co-authored-by: Sahil Chaturvedi <sahilc0@users.noreply.github.com> * Upgrade ts-sdk 0.4.2 and boltz-swap 0.3.1 (#399) * Fix send balance when sending btc with assets (#401) * fix max balance when sending btc with assets * fix keyboard when sending assets * style: rebrand Assets to Arkade Mint + redesign app cards (#398) * style(assets): rebrand Assets to Arkade Mint with pixel coin icon - Rename "Assets" to "Arkade Mint" across all asset screens (list, settings, mint success) - Replace placeholder "A" icon with Mario-style pixel coin in Arkade purple - New icon matches size/format of other app icons (55px/78px) * style(apps): redesign app cards with subtle surface treatment Replace Shadow border+borderPurple cards with whisper-surface style: - Subtle background tint instead of gray bg + harsh purple border - Tactile press state with scale(0.97) + background darken - Touch events matching Button component pattern (mouse + touch) - Icon aligned to top-left, description nested under title - Inline accessibility (role, tabIndex, keyboard handler) src/screens/Apps/Index.tsx * style: fix prettier formatting * fix(test): update test selectors after Assets → Arkade Mint rename The app card testId changed from 'app-assets' to 'app-arkade-mint' and the header/settings text changed accordingly. * fix(test): update 'Back to Assets' → 'Back to Arkade Mint' in tests MintSuccess button text was renamed but tests still referenced old text. --------- Co-authored-by: Sahil Chaturvedi <sahilc0@users.noreply.github.com> Co-authored-by: Andrew Camilleri <evilkukka@gmail.com> Co-authored-by: Pietro Grandi <dev@pietro.uno> * Upgrade ts-sdk@0.4.3 and boltz-swap@0.3.2 (#402) * Upgrade ts-sdk@0.4.3 and boltz-swap@0.3.2 * Update SW * feat: streamline onboarding — remove carousel, add dismissible PWA install banner (#375) * feat(onboarding): remove onboarding carousel, skip straight to wallet Remove the 4-step onboarding carousel (Onboard.tsx) and all supporting components (StepBars, Bullet, AlertBox, Announcement, Onboard1-4 SVGs). New users now go directly from Init → InitConnect → Wallet instead of through the carousel. The announcement/PSA system is also removed as it interrupted the flow without providing value. Files removed: - src/screens/Wallet/Onboard.tsx (carousel screen) - src/components/AlertBox.tsx, Announcement.tsx, Bullet.tsx, StepBars.tsx - src/icons/Onboard1-4.tsx (~10,800 lines of SVG illustrations) - src/providers/announcements.tsx (PSA announcement system) - Associated tests for removed components Files modified: - src/App.tsx: route to Init instead of Onboard for new wallets - src/screens/Init/*.tsx: navigate to InitConnect instead of InitSuccess - src/providers/navigation.tsx: remove Onboard from Pages enum - src/index.tsx: remove AnnouncementProvider wrapper - src/test/e2e/utils.ts: remove onboard steps from createWallet helper * feat(wallet): add dismissible PWA install banner and password nudge Add a new DismissibleBanner component used for both the PWA install prompt and the password creation nudge. The banner features Framer Motion enter/exit animations (EASE_OUT_QUINT, y:-24, scale:0.97), horizontal swipe-to-dismiss gesture, layout animation for smooth sibling reflow, and prefers-reduced-motion support with 44px touch targets. PWA install banner: - Mobile-only gating (isIOS || isAndroid) — hidden on desktop - Platform-specific descriptions (iOS share sheet vs Android install) - Module-level beforeinstallprompt capture for native install prompt - Respects persistent dismissed state via config.dismissedBanners Password nudge: - Replaced old AlertBox with DismissibleBanner (expanded layout) - Added nudgeVisible/nudgeCheckComplete to context for PWA banner priority coordination (PWA banner waits for nudge check) - Fixed error handling: .catch/.finally on async password check Config: replaced announcementsSeen with dismissedBanners (existing configs handled gracefully via ?? [] fallbacks). New files: - src/components/DismissibleBanner.tsx Modified: - src/screens/Wallet/Index.tsx (PWA banner integration) - src/providers/nudge.tsx (DismissibleBanner + error handling) - src/lib/pwa.ts (usePwaInstalled, beforeinstallprompt, promptPwaInstall) - src/lib/types.ts, src/providers/config.tsx (dismissedBanners) - src/ionic.css (--purple10 color variable) - src/test/setup.ts (matchMedia mock) * fix: address CodeRabbit review feedback - Password.tsx: reset restoring flag when navigating to InitConnect to prevent stale state from a previous restore attempt - DismissibleBanner.tsx: disable layout animation and popLayout mode when prefers-reduced-motion is active - Wallet/Index.tsx: only show Install action button when native prompt is available (Android); iOS shows instruction-only banner Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(wallet): clarify iOS PWA banner instruction text Update the iOS PWA install banner description to reference "the share icon in Safari's toolbar" instead of generic "the share button" so users know exactly where to look. * fix(pwa): return prompt outcome and auto-dismiss banner after install promptPwaInstall() now returns 'accepted' | 'dismissed' | null instead of void. On Android, the banner auto-dismisses after the user interacts with the native install prompt, rather than staying visible. * fix(banner): add haptic feedback to DismissibleBanner interactions Fire hapticSubtle() on button taps (Dismiss, Install, Set password) and on swipe-to-dismiss gesture, consistent with all other interactive elements in the app. * feat(onboarding): add animated SVG logo morph sequence with delight effects Redesign the Init screen with a rich onboarding animation: - OnboardingLogo: SVG cross-fade between Arcade, Space Invader, and Heart shapes with deep squash-stretch bounces using Framer Motion async animation controls. Final bounce flies logo to header position via FLIP. - PixelSplash: burst of purple pixel particles on each bounce - PixelSunrise: pixelated purple gradient at screen top (fixed position) - Three bullet points with outlined icon components (Bolt, Globe, ShieldCheck) replacing the old paragraph text - Reduced motion: all animations skip, content renders instantly Files: OnboardingLogo.tsx, PixelSplash.tsx, PixelSunrise.tsx, BoltOutline.tsx, GlobeOutline.tsx, ShieldCheckOutline.tsx, Init.tsx, ionic.css * style(onboarding): fix Prettier formatting in OnboardingLogo and Init * style(onboarding): smooth radial gradient, layout + status bar fixes - PixelSunrise: replace pixelated grid with smooth radial-gradient, remove all pixel dissolution code - Init: move content to bottom of screen (flex-end + paddingBottom), stack logo above title with optical alignment to bullet icons - Status bar: add apple-mobile-web-app-capable for PWA bleed-through, set theme-color to #8771BC (computed gradient top on white), fix manifest.json theme_color mismatch - Dynamic theme-color useEffect on Init screen for Safari tinting * style(onboarding): fix Prettier formatting in Init * fix(onboarding): stable fly target, gradient portal, dark mode prep - Always render content in DOM (hidden until ready) so logoTargetRef position is stable during fly animation instead of shifting on mount - Portal OnboardingLogo and PixelSunrise to document.body so they escape IonPage's max-width: 640px container on desktop - Add color-scheme light/dark to :root and .ion-palette-dark - Add color-scheme meta tag and body background-color for Safari - Sunrise animation synced with fly via onFlyStart callback - Snappier bounce physics: deeper squash, higher overshoot, faster timings * style(onboarding): fix Prettier formatting in Init.tsx * feat(onboarding): pixel morph animation, spring physics, loading bypass Logo morph animation: - Rewrite OnboardingLogo to use pixel-shapes.ts grid system instead of opacity crossfade between SVG path components - Arcade "A" always renders as clean SVG paths (never pixelated), while Invader and Heart shapes use pixel rects with CSS transform transitions - Spring-based bounce recovery (stiffness: 600, damping: 18, mass: 0.6) replaces scripted multi-step keyframes for natural overshoot feel - Morph + bounce happen simultaneously — shape swap at squash peak - Faster timing: 180ms initial pause, 60ms between morphs, ~1s total - Portal to document.body so logo escapes IonPage max-width on desktop Pixel splash particles: - Increase from 12-17 to 20-28 particles per burst - Wider velocity range (25-105) and more size variation (2.5-6.5px) Skip loading screen for new users: - New users (no wallet in storage) bypass ASP + JS capability gates, going straight to Init where the logo morph serves as intro visual - Wallet provider reads from localStorage synchronously via lazy useState initializer, eliminating one-frame Loading flash - "Create wallet" button stays disabled until ASP resolves Revert status bar changes: - All theme-color, color-scheme, and apple-mobile-web-app changes from this branch reverted — will be handled in a separate PR - Remove temp replay button and associated state Files: OnboardingLogo.tsx, PixelSplash.tsx, Init.tsx, App.tsx, wallet.tsx, index.html, manifest.json, ionic.css, index.css * fix(wallet): remove unused setWalletLoaded setter walletLoaded is now always true (synchronous init), so the setter is dead code. Replace useState with a constant to satisfy eslint. * Apply suggestion from @tiero Signed-off-by: Marco Argentieri <3596602+tiero@users.noreply.github.com> * fix: use named export for PageTransition to fix Rollup tree-shaking Rollup's module concatenation was dropping the default export definition while keeping the JSX references, causing 'PageTransition is not defined' at runtime. Named exports are handled more reliably. * fix: update e2e helpers for new onboarding flow (no more InitSuccess page) The onboarding flow now goes Init → InitConnect → Wallet directly, skipping the InitSuccess page. The createWallet() and restoreWallet() helpers were waiting for "Your new wallet is live!" / clicking "Go to wallet" which no longer exist, causing all Playwright tests to hang indefinitely. --------- Signed-off-by: Marco Argentieri <3596602+tiero@users.noreply.github.com> Co-authored-by: Sahil Chaturvedi <sahilc0@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Marco Argentieri <3596602+tiero@users.noreply.github.com> Co-authored-by: Andrew Camilleri <evilkukka@gmail.com> * perf(transactions): virtualise TransactionsList with @tanstack/react-virtual (#394) * test: add smoke test for TransactionsList with large tx history Reproduces the reported lag on wallets with several thousand transactions. TransactionsList renders every row into the DOM at once with no windowing; render time scales linearly (~1.8ms/tx in jsdom), so: 100 txs → 471ms ✓ 500 txs → 1,475ms ✗ 1000 txs → 2,258ms ✗ 3000 txs → 5,477ms ✗ 5000 txs → 9,206ms ✗ The fix is to virtualise the list (e.g. @tanstack/react-virtual). This test will serve as the regression gate once that is in place. https://claude.ai/code/session_01LDxnFdhREuPcK3yPCkQUMU * perf(transactions): virtualise TransactionsList with @tanstack/react-virtual Fixes the wallet freeze / extreme lag reported for wallets with several thousand transactions. Root cause ---------- TransactionsList rendered every Tx into the DOM unconditionally via a plain .map() call. With no windowing, render time scaled linearly with the transaction count (~1.8 ms/tx in jsdom, worse in a real browser due to layout and paint): Before fix (all DOM nodes mounted): 100 txs → 471 ms 500 txs → 1 475 ms 1000 txs → 2 258 ms 3000 txs → 5 477 ms 5000 txs → 9 206 ms Fix --- Replace the plain map() with @tanstack/react-virtual's useVirtualizer. Only the rows that fit in the viewport (+ a 5-row overscan buffer above and below) are ever mounted in the DOM. The total DOM node count is now O(visible rows) ≈ 15–25 regardless of wallet history size. After fix (virtual rows only): 100 txs → 4 ms ✓ 500 txs → 3 ms ✓ 1000 txs → 4 ms ✓ 3000 txs → 4 ms ✓ 5000 txs → 3 ms ✓ The list renders in a self-contained scrollable container (height: calc(100dvh - 380px), min-height: 200px) so the balance/buttons section above it remains static — a common pattern in mobile wallet UIs. Smoke test update ----------------- - Added a DOM-count assertion: at most MAX_DOM_ROWS (20) rows may be mounted at any one time, ensuring virtualisation cannot regress silently. - Retained the per-count render-time assertions (≤ 500 ms) as a belt-and- braces guard. https://claude.ai/code/session_01LDxnFdhREuPcK3yPCkQUMU * feat(TransactionsList): add ArrowUp/ArrowDown keyboard navigation with virtualizer scroll-sync Add focusedIndex state and handleListKeyDown on the parentRef scroll container. Arrow key presses call virtualizer.scrollToIndex(next) then requestAnimationFrame to focus the target Focusable row once it is mounted. Existing Enter → handleClick and Escape → focusOnOuterShell behaviour is preserved; Tab is unchanged. https://claude.ai/code/session_01LDxnFdhREuPcK3yPCkQUMU * fix(TransactionsList): guard focusRow and focusOnFirstRow against empty/out-of-range indices Add an early-return bounds check in focusRow (index < 0 || index >= txs.length) to prevent virtualizer.scrollToIndex and key(txs[index]) from executing on invalid indices. Move the txs.length === 0 guard before setFocused(true) in focusOnFirstRow so focused is never set true when there are no rows to navigate. The focusRow guard also covers the edge case in handleListKeyDown where txs.length === 0 would produce a -1 next index. https://claude.ai/code/session_01LDxnFdhREuPcK3yPCkQUMU * remove transactions smoke test https://claude.ai/code/session_01LDxnFdhREuPcK3yPCkQUMU * fix(keyboard): sync focusedIndex with actual DOM focus on row focus events (#397) * Initial plan * fix(keyboard): sync focusedIndex with actual DOM focus on row focus events Co-authored-by: tiero <3596602+tiero@users.noreply.github.com> * chore: remove accidentally committed package-lock.json Co-authored-by: tiero <3596602+tiero@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tiero <3596602+tiero@users.noreply.github.com> * fix: hide virtualizer scrollbar and address review feedback - Hide scrollbar on transaction list (reported by @Kukks) - Remove package-lock.json from .gitignore (feedback from @pietro909) - Remove redundant setFocusedIndex calls (CodeRabbit nitpick) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrew Camilleri <evilkukka@gmail.com> * fix: restore keyboard navigation on Apps list (#404) The app card redesign (#398) replaced the Focusable wrapper with a plain div, losing the focus ring styling and keyboard nav flow from #283. Re-wrap each App card in Focusable to restore focus indicator and Enter/Space activation. * fix: dynamic row height for virtualised transaction list (#405) Rows with asset info (e.g. "-14.7 BB") are taller than the 61px estimate, causing overlap. Enable measureElement so @tanstack/react-virtual measures actual DOM heights instead of relying on the fixed estimate. * Support undefined amounts and invalid invoices (#403) * fix sending to onchain address when having assets (#406) * remove tooltip from Text * hotfix * Fix coin list with assets (#407) * remove tooltip from Text * show amounts in separate line in coin list * fix InfoLine flash show (#408) * show loading in coin control (#409) * remove link from assets app * fix: dark mode banner button text invisible (#391998 on dark bg) - Switch DismissibleBanner button color from --purple to --purpletext - Add --purpletext dark mode override (#9678f7) for better contrast * fix: transaction list requires two clicks to navigate The onFocus handler on virtualised rows called setState (setFocused, setFocusedIndex), triggering a React re-render that destroyed the clicked DOM element before the click event completed. Convert both to refs since they're only used in event handlers, not render output. * Upgrade ts-sdk@0.4.4 and boltz-swap@0.3.3 (#411) * Fix receive amount in fiat only * Fix receive amount in fiat only * Fix collab exit (#413) --------- Signed-off-by: Marco Argentieri <3596602+tiero@users.noreply.github.com> Co-authored-by: João Bordalo <bordalix@users.noreply.github.com> Co-authored-by: louisinger <louis@vulpem.com> Co-authored-by: Andrew Camilleri <evilkukka@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Happy <yesreply@happy.engineering> Co-authored-by: louisinger <41042567+louisinger@users.noreply.github.com> Co-authored-by: OpenClaw Agent <agent@openclaw.dev> Co-authored-by: louisinger <louisinger@protonmail.com> Co-authored-by: Marco Argentieri <3596602+tiero@users.noreply.github.com> Co-authored-by: Sahil Chaturvedi <sahilc0@users.noreply.github.com> Co-authored-by: Sahil Chaturvedi <sahilchaturvedi@protonmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #390